Mention full XCode install requirement on macOS and soften WSL ver. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentonv
reviewed
Sep 21, 2022
kentonv
reviewed
Sep 21, 2022
kentonv
reviewed
Sep 21, 2022
dom96
force-pushed
the
dominik/readme-improvements
branch
from
8f62e0d to
c693b1b
Compare
dom96
force-pushed
the
dominik/readme-improvements
branch
from
c693b1b to
089306a
Compare
kentonv
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel supports building on macOS without a full XCode install but it's not a well tested path (I ran into a bug which broke even simple C++ hello world builds) so let's explicitly let readers know that they should install XCode.
Also WSL1 works just fine so no need to specifically ask for WSL2.