Merge pull request #257 from cloudflare/jsnell/clear-url-maybe

cloudflare · Jan 10, 2023 · 20ea1e0 · 20ea1e0
2 parents 9f9e74c + 1a7c135
commit 20ea1e0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/workerd/api/url-standard.c++ b/src/workerd/api/url-standard.c++
@@ -1633,6 +1633,12 @@ kj::Maybe<UrlRecord> URL::parse(
 URL::URL(jsg::UsvStringPtr url, jsg::Optional<jsg::UsvStringPtr> base)
     : inner(handleConstructorParse(url, kj::mv(base))) {}
 
+URL::~URL() noexcept(false) {
+  KJ_IF_MAYBE(searchParams, maybeSearchParams) {
+    (*searchParams)->maybeUrl = nullptr;
+  }
+}
+
 jsg::UsvString URL::getOrigin() {
   KJ_SWITCH_ONEOF(inner.getOrigin()) {
     KJ_CASE_ONEOF(opaque, OpaqueOrigin) {

diff --git a/src/workerd/api/url-standard.h b/src/workerd/api/url-standard.h
@@ -237,6 +237,8 @@ class URL: public jsg::Object {
 
   URL(jsg::UsvStringPtr url, jsg::Optional<jsg::UsvStringPtr> base = nullptr);
 
+  ~URL() noexcept(false) override;
+
   static inline jsg::Ref<URL> constructor(
       jsg::UsvString url,
       jsg::Optional<jsg::UsvString> base) {