Expose C api to handle PathEvent #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanmaurer
force-pushed
the
c_api_path_event
branch
4 times, most recently
from
6f8b6aa to
8a3d847
Compare
normanmaurer
force-pushed
the
c_api_path_event
branch
5 times, most recently
from
3423f50 to
51f57c5
Compare
normanmaurer
commented
Nov 21, 2023
normanmaurer
commented
Nov 21, 2023
|
So this seems to work... just tested it with my integration code |
normanmaurer
added a commit
to netty/netty-incubator-codec-quic
that referenced
this pull request
Nov 21, 2023
Motivation: How we used QuicConnectEvent to notify about connection migration was not correct at all. Let's remove it for now as we will introduce something better once cloudflare/quiche#1660 was merged into quiche. Modifications: Remove QuicConnectEvent Result: Get rid of incorrect implementation to prepare for adding a proper one
normanmaurer
added a commit
to netty/netty-incubator-codec-quic
that referenced
this pull request
Nov 21, 2023
Motivation: How we used QuicConnectEvent to notify about connection migration was not correct at all. Let's remove it for now as we will introduce something better once cloudflare/quiche#1660 was merged into quiche. Modifications: Remove QuicConnectEvent Result: Get rid of incorrect implementation to prepare for adding a proper one
normanmaurer
force-pushed
the
c_api_path_event
branch
2 times, most recently
from
e8676b4 to
b99516c
Compare
LPardue
reviewed
Nov 23, 2023
|
@LPardue all addressed |
LPardue
reviewed
Nov 24, 2023
|
There's a lot of passing pairs of wondering if maybe we should define a struct... |
I was thinking about it but decided against it as other functions that take those pairs dont use a struct as well. That said I am fine with adding a struct... Maybe lets wait for @ghedo to chime in |
normanmaurer
force-pushed
the
c_api_path_event
branch
2 times, most recently
from
3980108 to
7b54fa1
Compare
|
rebased |
ghedo
reviewed
Nov 27, 2023
Motivation: There was no C api exposed to allow handling PathEvent. Modifications: Expose c functions to handle PathEvent Result: Be able to handle and consume PathEvent
ghedo
force-pushed
the
c_api_path_event
branch
from
ce65fcb to
bcfec5a
Compare
ghedo
reviewed
Nov 27, 2023
ghedo
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
There was no C api exposed to allow handling PathEvent.
Modifications:
Expose c functions to handle PathEvent
Result:
Be able to handle and consume PathEvent