-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dns: Proxied
to become a boolean pointer
#595
Merged
jacobbednarz
merged 4 commits into
cloudflare:0.14
from
jacobbednarz:proxied-to-bool-ptr
Feb 22, 2021
Merged
dns: Proxied
to become a boolean pointer
#595
jacobbednarz
merged 4 commits into
cloudflare:0.14
from
jacobbednarz:proxied-to-bool-ptr
Feb 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
dmizelle
pushed a commit
to dmizelle/external-dns
that referenced
this pull request
Sep 15, 2021
In order for us to use some new features provided by cloudflare-go for the cloudflare provider (mainly around Cloudflare Access, etc.) we need to bump the version of cloudflare-go used. The only real change that needed to be done was that the `Proxied` field on `cloudflare.DNSRecord` structs changed from `bool` -> `*bool`. Upstream did this because in certain cases, a user could not flip from proxied -> DNS only (the library omitted sending `proxied = false` to the API) cloudflare/cloudflare-go#595
dmizelle
pushed a commit
to dmizelle/external-dns
that referenced
this pull request
Sep 15, 2021
In order for us to use some new features provided by cloudflare-go for the cloudflare provider (mainly around Cloudflare Access, etc.) we need to bump the version of cloudflare-go used. The only real change that needed to be done was that the `Proxied` field on `cloudflare.DNSRecord` structs changed from `bool` -> `*bool`. Upstream did this because in certain cases, a user could not flip from proxied -> DNS only (the library omitted sending `proxied = false` to the API) cloudflare/cloudflare-go#595
dmizelle
pushed a commit
to dmizelle/external-dns
that referenced
this pull request
Sep 15, 2021
In order for us to use some new features provided by cloudflare-go for the cloudflare provider (mainly around Cloudflare Access, etc.) we need to bump the version of cloudflare-go used. The only real change that needed to be done was that the `Proxied` field on `cloudflare.DNSRecord` structs changed from `bool` -> `*bool`. Upstream did this because in certain cases, a user could not flip from proxied -> DNS only (the library omitted sending `proxied = false` to the API) Other decent change was that most methods exported by the library now require `context.Context` to be passed in. Was rather trivial to get up. cloudflare/cloudflare-go#595
dmizelle
pushed a commit
to dmizelle/external-dns
that referenced
this pull request
Sep 15, 2021
In order for us to use some new features provided by cloudflare-go for the cloudflare provider (mainly around Cloudflare Access, etc.) we need to bump the version of cloudflare-go used. The only real change that needed to be done was that the `Proxied` field on `cloudflare.DNSRecord` structs changed from `bool` -> `*bool`. Upstream did this because in certain cases, a user could not flip from proxied -> DNS only (the library omitted sending `proxied = false` to the API) Other decent change was that most methods exported by the library now require `context.Context` to be passed in. Was rather trivial to get up. cloudflare/cloudflare-go#595 Signed-off-by: Devon Mizelle <[email protected]>
1 task
dmizelle
pushed a commit
to dmizelle/external-dns
that referenced
this pull request
Oct 1, 2021
In order for us to use some new features provided by cloudflare-go for the cloudflare provider (mainly around Cloudflare Access, etc.) we need to bump the version of cloudflare-go used. The only real change that needed to be done was that the `Proxied` field on `cloudflare.DNSRecord` structs changed from `bool` -> `*bool`. Upstream did this because in certain cases, a user could not flip from proxied -> DNS only (the library omitted sending `proxied = false` to the API) Other decent change was that most methods exported by the library now require `context.Context` to be passed in. Was rather trivial to get up. cloudflare/cloudflare-go#595 Signed-off-by: Devon Mizelle <[email protected]>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an inability to send a
false
proxied value to the API.After swapping to
*bool
Fixes #568