Skip to content

Commit

Permalink
Merge pull request #1506 from RazaGR/fix/domain-endpoint-method
Browse files Browse the repository at this point in the history
fix: domain list endpoint only accepts get requests
  • Loading branch information
jacobbednarz authored Feb 19, 2024
2 parents 3072a4b + 984abaa commit 619cc0f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions .changelog/1506.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
registrar: Fix request method to call domain list endpoint from POST to GET
```
2 changes: 1 addition & 1 deletion registrar.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ func (api *API) RegistrarDomain(ctx context.Context, accountID, domainName strin
func (api *API) RegistrarDomains(ctx context.Context, accountID string) ([]RegistrarDomain, error) {
uri := fmt.Sprintf("/accounts/%s/registrar/domains", accountID)

res, err := api.makeRequestContext(ctx, http.MethodPost, uri, nil)
res, err := api.makeRequestContext(ctx, http.MethodGet, uri, nil)
if err != nil {
return []RegistrarDomain{}, err
}
Expand Down
2 changes: 1 addition & 1 deletion registrar_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func TestRegistrarDomains(t *testing.T) {
defer teardown()

handler := func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, http.MethodPost, r.Method, "Expected method 'POST', got %s", r.Method)
assert.Equal(t, http.MethodGet, r.Method, "Expected method 'GET', got %s", r.Method)
w.Header().Set("content-type", "application/json")
fmt.Fprintf(w, `{
"success": true,
Expand Down

0 comments on commit 619cc0f

Please sign in to comment.