Clarifiy that allow_custom_ports flag affects WebSockets #17364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnbrady
requested review from
irvinebroque,
kflansburg,
mikenomitch,
GregBrimble and
a team
as code owners
workers-devprod
added
the
contribution
|
Congratulations @rnbrady, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm2a8222j11760cjq0p84hftm This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
elithrar
pushed a commit
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify that creating a WebSocket client with a call to
new WebSocket(url)will also obey theallow_custom_portsorignore_custom_portsflags, which I have verified through testing.I haven't created an issue as this is not a "significant change" as described in CONTRIBUTING.md.