Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Queues] add r2 event notifications disclaimer in src/content/docs/queues/get-started.mdx #17269

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

LA
Copy link
Contributor

@LA LA commented Oct 2, 2024

Summary

This PR adds a disclaimer to the queues get started documentation. The documentation currently states that:

You must create at least one producer Worker to publish messages onto your queue.

However, if you are using R2 Bucket Event Notifications, then you do not need a producer Worker. It does not state this in either the Queues or the Event Notifications documentation as far as I can tell.

Screenshots (optional)

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@LA LA requested review from elithrar, toddmantell, maheshwarip and a team as code owners October 2, 2024 05:55
@github-actions github-actions bot added product:queues Cloudflare Queues: https://developers.cloudflare.com/queues size/xs labels Oct 2, 2024
@KianNH KianNH enabled auto-merge (squash) October 15, 2024 09:14
Copy link
Contributor

@KianNH KianNH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@KianNH KianNH merged commit 9b628e5 into cloudflare:production Oct 15, 2024
9 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes a docs contribution, big or small label Oct 15, 2024
Copy link

holopin-bot bot commented Oct 15, 2024

Congratulations @LA, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm2a8ktn093860djwlksyhwfv

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes a docs contribution, big or small product:queues Cloudflare Queues: https://developers.cloudflare.com/queues size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants