Adding support for Ed448 digital signatures. #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbl
suggested changes
Feb 8, 2020
| H := sha3.NewShake256() | ||
| _, _ = H.Write(k.private[:]) | ||
| _, _ = H.Read(h[:]) | ||
| clamp(h[:Size]) |
There was a problem hiding this comment.
Is this used anywhere? I'm a bit confused about which parts of the private key in the keypair are which, so it's a bit hard for me to see that this is right.
There was a problem hiding this comment.
The first part is the scalar called s in the RFC and used blinding in the Schnorr signature. The second part is called prefix in the RFC and is used to derive the nonce. I agree that a comment would be nice.
bwesterb
reviewed
Mar 11, 2020
|
Based on your comments on this PR, I am preparing another PR for ed448 that is based on the goldilocks package. So I will close this for now. |
armfazh
added a commit
to armfazh/circl
that referenced
this pull request
Apr 7, 2020
armfazh
added a commit
to armfazh/circl
that referenced
this pull request
Apr 8, 2020
armfazh
added a commit
that referenced
this pull request
Apr 21, 2020
armfazh
added a commit
to armfazh/circl
that referenced
this pull request
Apr 21, 2020
armfazh
added a commit
that referenced
this pull request
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the digital signature Ed448.