Update boringssl to latest upstream commit (fixes #100) #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This supersedes #117. |
nox
force-pushed
the
bump-boringssl
branch
5 times, most recently
from
b099ec6 to
d64d6c7
Compare
Notable commits that cause code changes here: X509 fields notBefore and notAfter need to be specified https://boringssl-review.googlesource.com/c/boringssl/+/49349 X509ReqBuilder only accepts X509v1 now https://boringssl-review.googlesource.com/c/boringssl/+/52605 Some functions switched from int to size_t https://boringssl-review.googlesource.com/c/boringssl/+/54985 CECPQ2 support was dropped https://boringssl-review.googlesource.com/c/boringssl/+/58645 This is a breaking change.
nox
changed the title
inikulin
approved these changes
May 11, 2023
nmittler
added a commit
to nmittler/boring
that referenced
this pull request
Jul 28, 2023
This is needed by https://github.com/quinn-rs/quinn-boring. FYI this was originally going to be fixed by cloudflare#101, however that PR was closed and superceded by cloudflare#117, which was missing this fix. The original problem was caused by cloudflare#97, which updated boringssl to a version that included [a change that removed hmac.h from ssl.h](google/boringssl@05b360d). This PR adds an include for hmac.h, so it is again available through boring-sys.
nmittler
added a commit
to nmittler/boring
that referenced
this pull request
Jul 28, 2023
FYI this was originally going to be fixed by cloudflare#101, however that PR was closed and superseded by cloudflare#117, which was missing this fix. The original problem was caused by cloudflare#97, which updated boringssl to a version that included [a change that removed hmac.h from ssl.h](google/boringssl@05b360d). This PR adds an include for hmac.h, so it is again available through boring-sys.
nmittler
added a commit
to nmittler/boring
that referenced
this pull request
Aug 1, 2023
This was originally going to be fixed by cloudflare#101, however that PR was closed and superseded by cloudflare#117, which was missing this fix. The original problem was caused by cloudflare#97, which updated boringssl to a version that included [a change that removed hmac.h from ssl.h](google/boringssl@05b360d). This PR adds an include for hmac.h, so it is again available through boring-sys.
nox
pushed a commit
that referenced
this pull request
Aug 1, 2023
This was originally going to be fixed by #101, however that PR was closed and superseded by #117, which was missing this fix. The original problem was caused by #97, which updated boringssl to a version that included [a change that removed hmac.h from ssl.h](google/boringssl@05b360d). This PR adds an include for hmac.h, so it is again available through boring-sys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable commits that cause code changes here:
X509 fields notBefore and notAfter need to be specified
https://boringssl-review.googlesource.com/c/boringssl/+/49349
X509ReqBuilder only accepts X509v1 now
https://boringssl-review.googlesource.com/c/boringssl/+/52605
Some functions switched from int to size_t
https://boringssl-review.googlesource.com/c/boringssl/+/54985
CECPQ2 support was dropped
https://boringssl-review.googlesource.com/c/boringssl/+/58645
This is a breaking change.