Remove the LXD internal provider

Canonical have relicensed the LXD project to AGPLv3. This means that we can
no longer update the go LXD client without re-licensing GARM as AGPLv3. This
is not desirable or possible.

The existing code seems to be Apache 2.0 and all code that has already been
contributed seems to stay as Apache 2.0, but new contributions from Canonical
employees will be AGPLv3.

We cannot risc including AGPLv3 code now or in the future, so we will separate
the LXD provider into its own project which can be AGPLv3. GARM will simply
execute the external provider.

If the client code of LXD will ever be split from the main project and re-licensed
as Apache 2.0 or a compatible license, we will reconsider adding it back as a
native provider. Although in the long run, I believe external providers will
be the only option as they are easier to write, easier to maintain and safer to
ship (a bug in the provider does not crash GARM itself).

Signed-off-by: Gabriel Adrian Samfira <[email protected]>

config/config.go

@@ -223,7 +223,6 @@ type Provider struct {
 	// tokens to be used. This may happen if a provider has not yet been updated to support
 	// JIT configuration.
 	DisableJITConfig bool     `toml:"disable_jit_config" json:"disable-jit-config"`
-	LXD              LXD      `toml:"lxd" json:"lxd"`
 	External         External `toml:"external" json:"external"`
 }
 
@@ -233,10 +232,6 @@ func (p *Provider) Validate() error {
 	}
 
 	switch p.ProviderType {
-	case params.LXDProvider:
-		if err := p.LXD.Validate(); err != nil {
-			return errors.Wrap(err, "validating LXD provider info")
-		}
 	case params.ExternalProvider:
 		if err := p.External.Validate(); err != nil {
 			return errors.Wrap(err, "validating external provider info")

config/config_test.go

@@ -20,7 +20,6 @@ import (
 	"testing"
 	"time"
 
-	"github.com/cloudbase/garm/params"
 	"github.com/cloudbase/garm/util/appdefaults"
 	"github.com/stretchr/testify/require"
 )
@@ -76,15 +75,7 @@ func getDefaultDatabaseConfig(dir string) Database {
 }
 
 func getDefaultProvidersConfig() []Provider {
-	lxdConfig := getDefaultLXDConfig()
-	return []Provider{
-		{
-			Name:         "test_lxd",
-			ProviderType: params.LXDProvider,
-			Description:  "test LXD provider",
-			LXD:          lxdConfig,
-		},
-	}
+	return []Provider{}
 }
 
 func getDefaultGithubConfig() []Github {