Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the continueAfterTimeout parameter #30

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

healarconr
Copy link
Contributor

@healarconr healarconr commented Apr 16, 2021

Implements support for the continueAfterTimeout parameter mentioned in #29 by adding a new optional argument to the aurora_data_api.connect() function called continue_after_timeout. This argument is passed to the AuroraDataAPIClient and AuroraDataAPICursor and is used inside the cursor to add an additional execute_arg.

The corresponding unit test is skipped if an environment variable TEST_CONTINUE_AFTER_TIMEOUT is not True (it is considered False if it does not exist) to make it an opt-in test. The unit test is also skipped if using_mysql because the implementation uses the pg_sleep() function that does not exist in MySQL. An implementation of this test for MySQL could be added. I could not add it because I do not have an Aurora MySQL DB that I can access easily.

@healarconr healarconr marked this pull request as ready for review April 16, 2021 04:40
@kislyuk kislyuk merged commit 3d8fdf8 into cloud-utils:main Oct 29, 2021
@kislyuk
Copy link
Contributor

kislyuk commented Oct 29, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants