transport: fix get_request in linux #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killagu
requested review from
bergwolf,
jiangliu,
liubogithub and
eryugey
as code owners
jiangliu
reviewed
Mar 22, 2022
|
According to discussions here, tokio-rs/mio#928 , it seems like we could solve the problem with edge trigger? |
|
With FuseChannel#get_requests and Server#handle_message, we can only handle one message at the same loop. So we dependent the level-trigger mode. |
mio default add EPOLLET to event flags, so epoll will use edge-triggered mode. It may let poll miss some event, so manually register the fd with only EPOLLIN flag to use level-triggered mode.
|
Yes, let's fix it with level trigger for now and do a refactor later to switch to edge trigger. wdyt? @jiangliu @liubogithub |
jiangliu
approved these changes
Mar 22, 2022
I'm OK once we got the clear idea why it doesn't work with edge triggered signal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mio default add EPOLLET to event flags, so epoll will use
edge-triggered mode. It may let poll miss some event, so
manually register the fd with only EPOLLIN flag to
use level-triggered mode.