Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps #45

Merged
merged 1 commit into from
Nov 10, 2021
Merged

chore: update deps #45

merged 1 commit into from
Nov 10, 2021

Conversation

kapilt
Copy link
Contributor

@kapilt kapilt commented Nov 9, 2021

No description provided.

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #45 (c8a0c62) into master (5f2cec6) will not change coverage.
The diff coverage is n/a.

❗ Current head c8a0c62 differs from pull request most recent head a18759b. Consider uploading reports for the commit a18759b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   92.81%   92.81%           
=======================================
  Files           8        8           
  Lines         473      473           
=======================================
  Hits          439      439           
  Misses         34       34           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f2cec6...a18759b. Read the comment docs.

Copy link
Contributor

@marcoceppi marcoceppi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm, are there any concerns on pytest pushing to far forward and instead use something like dependabot to open PRs for version bumps so CI can run?

@kapilt
Copy link
Contributor Author

kapilt commented Nov 10, 2021

its a good question, generally i feel comfortable is ci is passing, but given our usage as a library, having broader compatibility feels good. we should catch things here early if we need to pin, it might be good to setup a nightly so we're not dependent on repo activity for validation of that assumption. generally we're using public interfaces with one exception, but that happened to be used by xdist as well. we've had pretty solid compatiblity across the 6x release series with one release exception that was relatively quickly resolved.

@kapilt kapilt merged commit 7f7a4fd into cloud-custodian:master Nov 10, 2021
@kapilt kapilt deleted the dep-update branch November 10, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants