Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xplatform path lookup, update readme #41

Merged
merged 3 commits into from
Apr 25, 2021

Conversation

kapilt
Copy link
Contributor

@kapilt kapilt commented Apr 25, 2021

use shutil.which for cross platform path lookups.

update readme docs on recording mode

closes #40

@codecov
Copy link

codecov bot commented Apr 25, 2021

Codecov Report

Merging #41 (61382cf) into master (17bb7e8) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage   92.64%   92.56%   -0.09%     
==========================================
  Files           8        8              
  Lines         462      457       -5     
==========================================
- Hits          428      423       -5     
  Misses         34       34              
Impacted Files Coverage Δ
pytest_terraform/tf.py 96.21% <ø> (-0.09%) ⬇️
pytest_terraform/plugin.py 96.77% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17bb7e8...61382cf. Read the comment docs.

@kapilt
Copy link
Contributor Author

kapilt commented Apr 25, 2021

coverage decrease is because we're deleting covered code.

@kapilt kapilt merged commit d6c8793 into cloud-custodian:master Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

find_binary should be platform aware
1 participant