Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcp - gke-cluster - fix augment when gke is not enabled #8073

Merged
merged 3 commits into from
Jan 9, 2023
Merged

gcp - gke-cluster - fix augment when gke is not enabled #8073

merged 3 commits into from
Jan 9, 2023

Conversation

thisisshi
Copy link
Member

closes: #8055

kapilt
kapilt approved these changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@kapilt kapilt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, although worth looking at why the query returns a None versus an empty list

@chase-replicated
Copy link

Any update on this? Seems like it was approved 3 weeks ago, are we just waiting on people to return from the holidays?

@thisisshi
Copy link
Member Author

@kapilt could you bypass the codecov check on this

@kapilt
Copy link
Collaborator

kapilt commented Jan 5, 2023

ack, as soon as ci finishes.

@kapilt kapilt merged commit 2bf18ea into cloud-custodian:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kapilt kapilt kapilt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

c7n_gcp fails with "Nonetype" object is not iterable when running policy against project with no clusters
3 participants
@thisisshi @chase-replicated @kapilt