tools/c7n-org - warn on AuthFailure when listing regions #7687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentnsw
pushed a commit
to newscorp-ghfb/cloud-custodian
that referenced
this pull request
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7494 allowed c7n-org to warn and continue in the case of
AccessDeniederror assuming target roles. #7685 raises a related error - anAuthFailurewhile describing regions. One way around that is to treat that the same way as anAccessDeniederror during the role-assume step: warn, continue, and effectively ignore that account.Some alternatives might be:
AuthFailuredifferently, either explicitly failing the policy on purpose or falling back to the default set of regionsCloses #7685