Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

c7n-org - no overwrite when merge acct tags to resource result #7642

Merged
merged 1 commit into from
Aug 11, 2022
Merged

c7n-org - no overwrite when merge acct tags to resource result #7642

merged 1 commit into from
Aug 11, 2022

Conversation

kentnsw
Copy link
Collaborator

@kentnsw kentnsw commented Aug 11, 2022

Sometimes resource fields got overwritten when merging account/project tags.

For example, run c7n-org report for gcp.service-account-key will get the wrong name because the name attribute got overwritten by the project name.

"Account","Region","Policy","name",...
"my-awsome-project","global","serviceaccount-key-rotate","my-awsome-project",...

@kentnsw kentnsw requested a review from kapilt as a code owner August 11, 2022 02:38
kapilt
kapilt approved these changes Aug 11, 2022
View reviewed changes
Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kapilt kapilt merged commit d139f83 into cloud-custodian:master Aug 11, 2022
@kentnsw kentnsw deleted the 2upstream/fix-report-fields-overwrited branch June 25, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kapilt kapilt kapilt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kentnsw @kapilt