Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GitHub URL for PyPi #7143

Closed
wants to merge 1 commit into from
Closed

add GitHub URL for PyPi #7143

wants to merge 1 commit into from

Conversation

andriyor
Copy link

@andriyor andriyor commented Mar 2, 2022

Warehouse now uses the project_urls provided to display links in the sidebar on this screen, as well as including them in API responses to help automation tool find the source code for Requests.

Docs: packaging.python.org/en/latest/guides/distributing-packages-using-setuptools/#project-urls

@andriyor andriyor requested a review from kapilt as a code owner March 2, 2022 09:32
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 2, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: andriyor / name: Andrii Oriekhov (6d7fc4a)

@ajkerrigan
Copy link
Member

Thanks for raising this @andriyor ! Our setup.py files are generated using details in each project's pyproject.toml file. And we do specify various project URLs there, so we may need to sort out how to get those URLs to show up in the generated setup.py files. Otherwise we'll keep clobbering your change here.

@kapilt
Copy link
Collaborator

kapilt commented Mar 3, 2022

going through this, it does look like project_urls is the modern spec format, and does result in warehouse/pypi display

@kapilt
Copy link
Collaborator

kapilt commented Mar 3, 2022

we probably need to update the poetry generated output, perhaps upstream in poetry, although that brings up a separate question of what poetry does with this metadata by default when its uploading which results in https://pypi.org/project/poetry/ .. we're still using twine on generated setup.py which is also something we could potentially let go of.

thanks for the pr @andriyor, stay safe 🇺🇦

@ajkerrigan
Copy link
Member

ajkerrigan commented Mar 3, 2022

I'm wondering if replacing python setup.py bdist_wheel with python -m build --wheel or poetry build --format wheel calls here would take care of this. Looking at some generated wheels locally, the METADATA of the python setup.py version has a Home-page line but no Project-URL entries. The python -m build and poetry build versions add URLs taken from pyproject.toml:

Project-URL: Bug Tracker, https://github.com/cloud-custodian/cloud-custodian/issues
Project-URL: Documentation, https://cloudcustodian.io/docs
Project-URL: Repository, https://github.com/cloud-custodian/cloud-custodian

@thisisshi
Copy link
Member

/easycla

@andriyor andriyor closed this Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants