Add retries for addtional response codes #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…requests. For 503s, requests can be retried after between 2-4 seconds, for 502 and 504s, we want a retry every 60-90 seconds, with that number increasing each time we retry
thomasst
reviewed
Jun 10, 2020
closeio_api/__init__.py
Outdated
| request again. | ||
| """ | ||
| if status_code == 503: | ||
| return randint(2, 4) |
There was a problem hiding this comment.
This should also have a backoff.
There was a problem hiding this comment.
Done in bceed63. Note: I also didn't exponentially back off on this one either, because 503s should be able to be retried practically instantaneously, so it felt like overkill.
If you'd rather that, let me know.
thomasst
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds retries for
503status codes and502and504status codes onGETrequests.In terms of intervals for retries, for 503s, each retry we chose a random number between 2 - 4 seconds.
For 502 or 504 GETs, we choose a random integer between 60 and 90 seconds and multiply that by the number of current retries.
I also bumped up the version number to
1.3even though we never actually released1.2to PyPI.