Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework event contexts in C# #240

Merged
merged 6 commits into from
Feb 7, 2025
Merged

Conversation

kazimuth
Copy link
Contributor

@kazimuth kazimuth commented Feb 7, 2025

Description of Changes

clockworklabs/SpacetimeDB#2226

API

  • This is an API breaking change to the SDK

callbacks are better

Requires SpacetimeDB PRs

clockworklabs/SpacetimeDB#2226

Testsuite

SpacetimeDB branch name: jgilles/csharp-better-events

Testing

  • quickstart
  • blackholio

@kazimuth kazimuth changed the base branch from master to staging February 7, 2025 20:41
Copy link
Contributor

@gefjon gefjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request 🙏 , but then this looks good. Thanks so much for the quick work in this trying time!

src/Event.cs Outdated Show resolved Hide resolved
@kazimuth kazimuth enabled auto-merge (squash) February 7, 2025 21:54
@kazimuth kazimuth merged commit 06df3f1 into staging Feb 7, 2025
6 checks passed
@kazimuth kazimuth deleted the jgilles/csharp-better-events branch February 7, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants