Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed AuthToken.GetTokenKey() to private #237

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from

Conversation

rekhoff
Copy link

@rekhoff rekhoff commented Feb 5, 2025

Description of Changes

Changed AuthToken.GetTokenKey() to private. Use AuthToken.Token to get token.

API

  • This is an API breaking change to the SDK

Requires SpacetimeDB PRs

List any PRs here that are required for this SDK change to work

Testsuite

If you would like to run the your SDK changes in this PR against a specific SpacetimeDB branch, specify that here. This can be a branch name or a link to a PR.

SpacetimeDB branch name: master

Testing

Tested opening existing projects. Replacing AuthToken.GetTokenKey() with AuthToken.Token resolved all issues during tests.

Changed `AuthToken.GetTokenKey()` to private. Use `AuthToken.Token` to get token.
@rekhoff rekhoff linked an issue Feb 5, 2025 that may be closed by this pull request
@rekhoff rekhoff changed the base branch from master to staging February 5, 2025 23:06
@rekhoff rekhoff self-assigned this Feb 6, 2025
@rekhoff
Copy link
Author

rekhoff commented Feb 6, 2025

This PR is failing on Unity tests of Blackolio, likely due to use of AuthToken.GetTokenKey(). Will need to make a modification to Blackholio project to resolve this issue before retesting this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Different address printing order between client and server
1 participant