Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update easylist.txt to a newer version #2125

Closed
wants to merge 1 commit into from
Closed

Update easylist.txt to a newer version #2125

wants to merge 1 commit into from

Conversation

ameshkov
Copy link
Contributor

@ameshkov ameshkov commented Aug 6, 2021

No description provided.

@ameshkov ameshkov requested a review from remusao as a code owner August 6, 2021 12:27
@remusao
Copy link
Collaborator

remusao commented Aug 6, 2021 •
edited
Loading

Thanks Andrey, I have a couple of high level comments that maybe we can discuss here since Manish and I briefly talked about an update of the rules:

  • I think currently the easylist.txt file contains both EasyPrivacy and EasyList network filter combined.
  • There is a benefit in keeping the rules stable over time so that progress can be tracked over time (same rules but content bocking engines improving)
  • The requests data set is quite old now and it is not clear if it is as relevant to measure filters from 2021 with requests from 2017 or so.

What do you think?

Edit: but I see your point from #2114 (comment)

@ameshkov
Copy link
Contributor Author

ameshkov commented Aug 6, 2021

Yeah, both easylist.txt and requests.json need to be updated at the same time.

Would it be enough to just run create_dataset.js?

@remusao
Copy link
Collaborator

remusao commented Aug 6, 2021 •
edited
Loading

Would it be enough to just run create_dataset.js?

Unfortunately no. There was an other script that was using a pool of puppeteer workers to do the crawling on top domains (it might still be somewhere in the Git history), then this create_dataset.js was doing the shuffling and preparing the final dataset from this raw dump made by the puppeteer pool thingy. It's not super hard to do and mostly you need to let it run for a few hours on a cloud instance so it could be done if someone as a bit of time. If there is interest we can revive it and work on a version that anyone can run to refresh the dataset (Cc @mjethani)

Edit: actually yes sorry, I wrote too quickly. It looks like this create_dataset.js is the original script that was used, I got confused with shuffle_dataset.js. Then I guess we can start from this script and see if it still works. I ran it only once for the original study a few years ago.

@mjethani
Copy link
Contributor

mjethani commented Aug 6, 2021

@ameshkov @remusao I have a compromise solution here: #2126 It gets all the blockers working correctly with the current set of filters, it keeps the discrepancies between implementations documented in the code, and it lets us move forward as far as further optimization work is concerned.

@remusao remusao added the PR: Internal 🏠 Changes only affect internals label Aug 6, 2021
@mjethani
Copy link
Contributor

There are 996 domains being passed to the collectDataset() function. @remusao what are these domains? How do we update this list?

@remusao
Copy link
Collaborator

remusao commented Aug 10, 2021

There are 996 domains being passed to the collectDataset() function. @remusao what are these domains? How do we update this list?

Good question. I think that I created this list of top domains based on popular domains seen in Cliqz search at the time (then randomized it and dumped in the file as you see it now). But I can't remember for sure. I'm guessing we could also use Alexa top domains or https://tranco-list.eu/.

@mjethani
Copy link
Contributor

It looks like this create_dataset.js is the original script that was used, I got confused with shuffle_dataset.js. Then I guess we can start from this script and see if it still works. I ran it only once for the original study a few years ago.

Cool, I'll try to run it on my EC2 instance.

I'm guessing we could also use Alexa top domains or https://tranco-list.eu/.

Let's try with the current list to see if it works.

@remusao
Copy link
Collaborator

remusao commented Aug 10, 2021

@mjethani Sounds good, thanks! I hope it still works :) But the script is fairly simple so it should not be too hard to fix if something is broken.

@mjethani
Copy link
Contributor

But the script is fairly simple so it should not be too hard to fix if something is broken.

It's running now and the output looks like this:

{"domainId":2,"pageId":3,"frameUrl":"https://www.amazon.com/","url":"https://www.amazon.com/","cpt":"document"}
{"domainId":8,"pageId":9,"frameUrl":"https://www.imdb.com/","url":"https://www.imdb.com/","cpt":"document"}
{"domainId":4,"pageId":5,"frameUrl":"https://www.reddit.com/","url":"https://www.reddit.com/","cpt":"document"}
{"domainId":10,"pageId":11,"frameUrl":"https://www.google.com/","url":"https://www.google.com/","cpt":"document"}
{"domainId":0,"pageId":1,"frameUrl":"https://www.wikipedia.org/","url":"https://www.wikipedia.org/","cpt":"document"}

Did you have to get rid of the domainId and pageId fields?

@remusao
Copy link
Collaborator

remusao commented Aug 10, 2021

@mjethani From what I can recall, this information is then used by the following script https://github.com/cliqz-oss/adblocker/blob/master/packages/adblocker-benchmarks/shuffle_dataset.js#L40 to shuffle the dataset in such a way that requests observed for a given page load are kept in the same order, but page loads themselves are shuffled (to make it a bit more realistic than just shuffling all requests).

@mjethani
Copy link
Contributor

Here we go: https://manishjethani.io/tmp/shuffled-1.json.gz

This is a temporary URL.

Edit Makefile to use this URL instead and observe the results.

@@ -14,7 +14,7 @@ endif
 all: deps run
 
 requests.json:
-       curl https://cdn.cliqz.com/adblocking/requests_top500.json.gz | gunzip \
+       curl https://manishjethani.io/tmp/shuffled-1.json.gz | gunzip \
                | sed -e '$$ ! s/$$/,/; 1 s/^/\[/; $$ s/$$/]/' > requests.json
 
 ./node_modules/@gorhill/ubo-core:

@gorhill @remusao uBlock Origin and Cliqz are once again blocking fewer requests.

We are really going to need that test suite.

@mjethani
Copy link
Contributor

For future reference about create_dataset.js:

  1. npm install puppeteer-pool
  2. rm -rf node_modules/puppeteer
  3. git clone https://github.com/puppeteer/puppeteer.git
  4. npm install puppeteer
  5. node create_dataset.js
  6. node shuffle_dataset.js

puppeteer-pool uses a very old version of puppeteer and the code expects a newer version.

On Ubuntu I also had to install a number of missing libraries. It may take a few tries before the script finally works. If it gives no output, it's not doing anything and there's a problem with the configuration.

@remusao
Copy link
Collaborator

remusao commented Aug 10, 2021

Thanks a lot @mjethani! Maybe we could migrate the script to use the more recent https://github.com/thomasdondorf/puppeteer-cluster

Also, maybe would it make sense to create a Dockerfile to simplify running the setup in the future, without having to figure out all the dependencies required first.

@mjethani
Copy link
Contributor

@gorhill uBlock Origin:

[
  {
    "url": "https://www.google-analytics.com/j/collect?v=1&_v=j92&a=393452224&t=pageview&_s=1&dl=https%3A%2F%2Fthechive.com%2F&ul=en-us&de=UTF-8&dt=An%20improbable%20hall%20of%20fame%20journey%20and%20the%201.000%20batting%20average%20(8%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Actors%20you%20WON%E2%80%99T%20BELIEVE%20are%20turning%2060%20this%20year%20(16%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Animals%20prove%20you%20can%20find%20friends%20in%20the%20most%20unlikely%20of%20places%20(22%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09A%20Bikini%20a%20day%20keeps%20the%20Bikini%20Doctor%20away%E2%80%A6%20right%3F%20(35%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Daily%20Morning%20Awesomeness%20(40%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Turns%20out%20marriage%20is%20a%20big%20f%40%23%25ing%20joke%20(31%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Kids%20bring%20some%20crazy%20sh*t%20to%20show%20and%20tell%20(19%20GIFs)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Blazing%20hot%20Dutch%20runner%20Lieke%20Klaver%20won%20the%20Olympics%20(21%20photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Quentin%20Tarantino%20explains%20why%20he%E2%80%99ll%20NEVER%20give%20his%20mom%20a%20cent%20of%20his%20film%20money%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Daily%20Afternoon%20Randomness%20(49%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Keep%20calm%20and%20tug%20on%20(38%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Some%20small%20hills%20are%20worth%20dying%20on%2C%20just%20ask%20these%20folks%20(20%20GIFs)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09The%20best%20tweets%20from%20parents%20of%20all%20time%20last%20week%20(25%20photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Folks%20share%20memories%20of%20their%20fathers%20who%20passed%20away%20(21%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Daily%20Morning%20Awesomeness%20(38%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09What%E2%80%99s%20the%20Worst%20Pain%20You%E2%80%99ve%20Ever%20Felt%3F%20(15%20GIFs)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09All%20systems%20GO!%20Prepare%20for%20Liftoff%20in%203%E2%80%A62%E2%80%A61%E2%80%A6%20(45%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Read%20Between%20the%20Tan%20Lines%20(35%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09My%20sweet%20Big%20Mouth%20Billy%20Bass%2C%20look%20what%20they%20did%20to%20you!%20(Video)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Weekend%20Afternoon%20Randomness%20(36%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09GIFs%20prove%3A%20Can%E2%80%99t%20out-Random%20the%20internet%20(25%20GIFs)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09These%20male%20authors%20prove%20they%20know%20nothing%20about%20women%E2%80%99s%20bodies%20(31%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Nice%20Design%20Work%20Ya%20Absolute%20Prick!%20(23%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Upon%20closer%20inspection%20HOLY%20S***!%20(35%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Weekend%20Morning%20Awesomeness%20(37%20photos)&sd=24-bit&sr=800x600&vp=800x600&je=0&_u=YEBAAAABAAAAAC~&jid=331000972&gjid=1930197999&cid=827252379.1628628622&tid=UA-6481362-1&_gid=1175243576.1628628622&_r=1&gtm=2wg891P83WPK&cg2=homepage&cd2=&cd3=homepage&cd4=&cd5=&cd13=C_JS%3A%5Bobject%20Object%5Dundefined%2CmetaId%3Ano%2CbodyPostId%3Ano&z=388502388",
    "frameUrl": "https://thechive.com/",
    "cpt": "xhr",
    "filter": "/collect?*&cid="
  },
  {
    "url": "https://www.google-analytics.com/j/collect?v=1&_v=j92&a=1523452421&t=event&ni=1&qt=0&_s=1&dl=https%3A%2F%2Fwww.lifewire.com%2F&dr=&dp=%2F&ul=en-us&de=UTF-8&dt=Lifewire%3A%20Tech%20News%2C%20Reviews%2C%20Help%20%26%20How-Tos&sd=24-bit&sr=800x600&vp=800x600&je=0&ec=AB%20Tests&ea=Map%20Vertical%20Proctor%20Data&el=%7B%2253%22%3A%22rightRailOffset%20%7C%20active%20%7C%20active%20-%20Move%20right-rail__offset%20to%20content%20well%20%7C%201%22%2C%2257%22%3A%22journeysNextUp%20%7C%20version4%20%7C%20Version%204%20%7C%204%22%2C%2264%22%3A%22railVideoMargin%20%7C%20control%20%7C%20Keep%20intersection%20margin%20at%20250px%20%7C%200%22%2C%2275%22%3A%22pageViewEventLoaded%20%7C%20delay%20%7C%20Page%20View%20triggered%20on%20Document%20Load%20%7C%201%22%2C%2278%22%3A%22featuredLinkExternal%20%7C%20buttonNew%20%7C%20Button%20new%20style%20%7C%202%22%2C%2299-0%22%3A%22includeIAS%20%7C%20includeIAS%20%7C%20Include%20IAS%20script%20%7C%201%22%2C%2299-1%22%3A%22mediaGrid%20%7C%20active%20%7C%20active%20%7C%201%22%2C%2299-2%22%3A%22mapFBValues%20%7C%20hasFBMap%20%7C%20Using%20the%20FB%20map%20values%20%7C%201%22%2C%2299-3%22%3A%22pageLoadDesktopT4%20%7C%20control%20%7C%20Control%20(lazy-load)%20%7C%200%22%2C%2299-4%22%3A%22rtbBiddingLatencyBuffer%20%7C%20control%20%7C%20control%20%7C%200%22%2C%2299-5%22%3A%22scMobileAdPositions%20%7C%20control%20%7C%20Control%20%7C%200%22%2C%2299-6%22%3A%22scDesktopAdPositions%20%7C%20control%20%7C%20control%20%7C%200%22%2C%2299-7%22%3A%22leaderboardacOffset%20%7C%20control%20%7C%20Control%20(default%20offset%20of%20400)%20%7C%200%22%2C%2299-8%22%3A%22cmpTimeout%20%7C%20t1%20%7C%20Test%201%20%7C%201%22%2C%2299-9%22%3A%22pbTeads%20%7C%20teads%20%7C%20Teads%20%7C%201%22%2C%2299-10%22%3A%22prebid%20%7C%20ixId%20%7C%20Active%20with%20index%20identity%20adapter%20%7C%202%22%2C%2299-12%22%3A%22cssJsInjection%20%7C%20control%20%7C%20Control%20(no%20change)%20%7C%200%22%2C%2299-13%22%3A%22rtbTimeout%20%7C%20test2%20%7C%20test2%20%7C%202%22%2C%2299-14%22%3A%22commerceButtonOptimization_text%20%7C%20control%20%7C%20control%20%7C%200%22%2C%2299-15%22%3A%22cssJsInjection_tmobiletest%20%7C%20control%20%7C%20control%20%7C%200%22%2C%2299-20%22%3A%22useRTBforVideoAds%20%7C%20control%20%7C%20%7C%200%22%7D&_u=YEBAAUABAAAAAC~&jid=1097827104&gjid=278702358&cid=1501590216.1628628774&tid=UA-44417706-3&_gid=27435473.1628628774&_r=1&gtm=2wg8915P3SZGS&cd13=GTM-5P3SZGS&cd14=43&cd42=Mozilla%2F5.0%20(X11%3B%20Linux%20x86_64)%20AppleWebKit%2F537.36%20(KHTML%2C%20like%20Gecko)%20HeadlessChrome%2F93.0.4577.0%20Safari%2F537.36&cd46=%7B%22robots%22%3A%22max-image-preview%3Alarge%2C%20NOODP%2C%20NOYDIR%22%2C%22fb%3Aapp_id%22%3A%221833670990199396%22%7D&cd48=Direct&cd53=rightRailOffset%20%7C%20active%20%7C%20active%20-%20Move%20right-rail__offset%20to%20content%20well%20%7C%201&cd57=journeysNextUp%20%7C%20version4%20%7C%20Version%204%20%7C%204&cd64=railVideoMargin%20%7C%20control%20%7C%20Keep%20intersection%20margin%20at%20250px%20%7C%200&cd75=pageViewEventLoaded%20%7C%20delay%20%7C%20Page%20View%20triggered%20on%20Document%20Load%20%7C%201&cd78=featuredLinkExternal%20%7C%20buttonNew%20%7C%20Button%20new%20style%20%7C%202&z=1164935443",
    "frameUrl": "https://www.lifewire.com/",
    "cpt": "xhr",
    "filter": "/collect?*&cid="
  }
]

By the way, this is some tedious work, there should be a mode to automatically compare the results between two content blockers.

@mjethani
Copy link
Contributor

Here we go: https://manishjethani.io/tmp/shuffled-1.json.gz

This is a temporary URL.

Edit Makefile to use this URL instead and observe the results.

@antonok-edm adblock-rs crashes if you pass type as "ping":

(node:48011) UnhandledPromiseRejectionWarning: TypeError: failed to downcast any to string
    at Engine.check (/adblocker/packages/adblocker-benchmarks/node_modules/adblock-rs/native/index.js:27:24)
    at Brave.match (/adblocker/packages/adblocker-benchmarks/blockers/brave.js:31:24)
    at main (/adblocker/packages/adblocker-benchmarks/run.js:264:26)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

But otherwise the results are correct.

@mjethani
Copy link
Contributor

@antonok-edm adblock-rs crashes if you pass type as "ping"

Sorry, the value actually seems to be undefined. Not sure if this would be considered a bug in adblock-rs. I'll try passing null or "other".

@mjethani mjethani mentioned this pull request Aug 10, 2021
Merged
@antonok-edm antonok-edm mentioned this pull request Aug 11, 2021
Open
@antonok-edm
Copy link

Yep, "ping" should be supported already. I agree that errors from the JS bindings are not ideal; I filed brave/adblock-rust#182 to track improvements on that front.

@gorhill
Copy link
Contributor

gorhill commented Aug 11, 2021

@gorhill uBlock Origin

Pretty sure it's related to this issue: uBlockOrigin/uBlock-issues#1207. Those requests would still be blocked in uBO because of other filter lists enabled by default.

@remusao
Copy link
Collaborator

remusao commented Aug 11, 2021

I think Cliqz has the same issue where we stop looking if the URL is too long, for performance reason.

@mjethani
Copy link
Contributor

Edit Makefile to use this URL instead and observe the results.

To compare the updated data set with the current data set in the repo using the same version of easylist.txt:

  • Current: 82,388 out of 221,451 (~37%) requests blocked
  • Updated: 90,540 out of 233,347 (~39%) requests blocked

@mjethani
Copy link
Contributor

To compare the updated data set with the current data set in the repo using the same version of easylist.txt

With easylist.txt and easyprivacy.txt taken from ../adblocker/assets/easylist/ and concatenated together, here are the results:

  • Current: 80,929 out of 221,451 (~37%) requests blocked
  • Updated: 94,296 out of 233,347 (~40%) requests blocked

@mjethani mjethani mentioned this pull request Aug 11, 2021
Merged
@mjethani
Copy link
Contributor

@antonok-edm Brave appears to have a problem blocking these:

  {
    url: 'https://pre.glotgrx.com/nflrc.gif?cb=1628628606200442&ver=1.2r81&qid=838363f5039363f5730343&p=361&s=filehippo.com&x=SS1&cid=407&od1=&od2=&adtg=0&nci=&nai=802444876582289410&si=&ai=&nsi=&co=0&cstm1=&cstm2=&cstm3=&rnd=pxiygoxnev5b&impid=la-bdr49_1628628603018_1628674053957&tps=13&ver1=2.2.3&kqt=45&di=&xc=946e848f9d92851adb7e490595ea8eaa7576e21e&1=d43be3f7b2d7c60b11d13e83b7df8a13&2=0.0&3=600_800_600_800_24_24_1&5=%7B%220%22%3A%7B%7D%7D&6=2&7={%22e%22:%223%22,%22m%22:%220%22,%22f%22:%223428%22}&ats=0&atf=&dbgcid=407&ifm=1&penv=b&pt=&ptbp=&tw=0&ldp=2&icpl=25&icp=https%253A//filehippo.com&irfl=26&irf=https%253A//filehippo.com/&cty=4&fcs=0&flky=ver-fl-6-qid-fl-22-p-fl-3-s-fl-13-x-fl-3-cid-fl-3-od1-fl-0-od2-fl-0-adtg-fl-1-nci-fl-0-nai-fl-18-si-fl-0-ai-fl-0-nsi-fl-0-co-fl-0-cstm1-fl-0-cstm2-fl-0-cstm3-fl-0-rnd-fl-12-impid-fl-36-tps-fl-0-cb-fl-13-ver1-fl-5-kqt-fl-2-di-fl-0-xc-fl-40-&spfp=0&spfnp=0&sp1=Chromefl_andLinux&sp2=Chromefl_andLinux&adv=0&det=1&adb=0&iip=0&spf=0&adc=1&adcd=i0_f0_o0_e0&vps=728x90&gpu=Google%20SwiftShader&ncf=4g_9.1_undefined_null_0_undefined_false&fli=&flerr=0&trim=&fio=102',
    frameUrl: 'https://aax-us-east.amazon-adsystem.com/e/dtb/admi?b=Ius4CxMf4beL7AhHCgIFA9kAAAF7MdRROQEAAAxpAa5-wW4&rnd=173021021471628628604187&pp=1u87f28&p=1b0hjb4&crid=589-658862_2_S',
    cpt: 'image',
    filter: '=728x90&'
  },
  {
    url: 'https://delivered-by-madington.com/client/aller/magazine/serve-template?layout=combined&magazine=vhi&bgc=rgb(222,%20222,%20222)&sbgc=rgb(196,%20196,%20196)&cover=&msgBgColor=rgb(255,%20255,%20255)&msgTxtColor=rgb(7,%207,%207)&headerTop=VAKRE%20HJEM%20%26%20INTERI%C3%98R&headerBottom=%2B%20salatbestikk%20og%20vase&magOne=https://delivered-by-madington.com/mess/client-content/uploads/OlInRmpdMK6UlrtWJzln/media/ed49ec04-e89d-408f-9e53-a0db5f1f3872.jpg&magTwo=https://delivered-by-madington.com/mess/client-content/uploads/OlInRmpdMK6UlrtWJzln/media/6e0ab345-511b-47a3-b708-8e29768dd260.jpg&magThree=https://delivered-by-madington.com/mess/client-content/uploads/OlInRmpdMK6UlrtWJzln/media/9110579f-e2bb-4929-b775-e2c53d36f160.jpg&promo=https://delivered-by-madington.com/mess/client-content/uploads/OlInRmpdMK6UlrtWJzln/media/57903f8b-4e3c-4e5d-96c6-bee9a2ac78f9.jpg&tintColor=rgba(17,%208,%208,%200.5)&priceColor=rgb(255,%20255,%20255)&abovePrice=4%20utgaver&price=319%2C-&belowPrice=Spar%20925%2C-&ctaBgColor=rgb(60,%20199,%20166)&ctaBgHoverColor=rgb(52,%20181,%20151)&ctaColor=rgb(255,%20255,%20255)&cta=Abonner%20n%C3%A5!&width=980&height=300&clickTag=https://adclick.g.doubleclick.net/pcs/click%253Fxai%253DAKAOjsuZX1_-cM0MeNB-Yy-Vc_38jvg9ntRhvnS-nYgV79HFKL6cVU9EZEptv5J4tIrX6FZGq44PYnkCIEjuD2ezHnGXqi-WlM1ZmxU_WQJPCvIx_H-ui6MWaUyU-NrwQie0SHbrYo-ON5Iv4haO_PIWfOovD0vHw7_VcnhjNLFt4_4NH1NjOG888yRqxAd3tUfvm7Jldw_y4tDdOMp0v8uYzdqNud6GzHY3SjmUbB3STUDzLv57GhwTzY0aDL7OnyeMglmBu1Hh2wBtXlDuuYjrws3t3yEhqq9Z4iSO_BvZwtoe8a6FUT4orZx47pSkXA%2526sig%253DCg0ArKJSzPMj03LfkVgxEAE%2526fbs_aeid%253D%255Bgw_fbsaeid%255D%2526urlfix%253D1%2526adurl%253Dhttps://kampanje.allershopping.no/vhi-4-319-bestikkvase%3Futm_source%3Dbvhi_estikkvase_jul21%26utm_medium%3Dhouse%26utm_campaign%3Dvhi-4-319-bestikkvase',
    frameUrl: 'https://delivered-by-madington.com/client/aller/magazine/serve-template?layout=combined&magazine=vhi&bgc=rgb(222,%20222,%20222)&sbgc=rgb(196,%20196,%20196)&cover=&msgBgColor=rgb(255,%20255,%20255)&msgTxtColor=rgb(7,%207,%207)&headerTop=VAKRE%20HJEM%20%26%20INTERI%C3%98R&headerBottom=%2B%20salatbestikk%20og%20vase&magOne=https://delivered-by-madington.com/mess/client-content/uploads/OlInRmpdMK6UlrtWJzln/media/ed49ec04-e89d-408f-9e53-a0db5f1f3872.jpg&magTwo=https://delivered-by-madington.com/mess/client-content/uploads/OlInRmpdMK6UlrtWJzln/media/6e0ab345-511b-47a3-b708-8e29768dd260.jpg&magThree=https://delivered-by-madington.com/mess/client-content/uploads/OlInRmpdMK6UlrtWJzln/media/9110579f-e2bb-4929-b775-e2c53d36f160.jpg&promo=https://delivered-by-madington.com/mess/client-content/uploads/OlInRmpdMK6UlrtWJzln/media/57903f8b-4e3c-4e5d-96c6-bee9a2ac78f9.jpg&tintColor=rgba(17,%208,%208,%200.5)&priceColor=rgb(255,%20255,%20255)&abovePrice=4%20utgaver&price=319%2C-&belowPrice=Spar%20925%2C-&ctaBgColor=rgb(60,%20199,%20166)&ctaBgHoverColor=rgb(52,%20181,%20151)&ctaColor=rgb(255,%20255,%20255)&cta=Abonner%20n%C3%A5!&width=980&height=300&clickTag=https://adclick.g.doubleclick.net/pcs/click%253Fxai%253DAKAOjsuZX1_-cM0MeNB-Yy-Vc_38jvg9ntRhvnS-nYgV79HFKL6cVU9EZEptv5J4tIrX6FZGq44PYnkCIEjuD2ezHnGXqi-WlM1ZmxU_WQJPCvIx_H-ui6MWaUyU-NrwQie0SHbrYo-ON5Iv4haO_PIWfOovD0vHw7_VcnhjNLFt4_4NH1NjOG888yRqxAd3tUfvm7Jldw_y4tDdOMp0v8uYzdqNud6GzHY3SjmUbB3STUDzLv57GhwTzY0aDL7OnyeMglmBu1Hh2wBtXlDuuYjrws3t3yEhqq9Z4iSO_BvZwtoe8a6FUT4orZx47pSkXA%2526sig%253DCg0ArKJSzPMj03LfkVgxEAE%2526fbs_aeid%253D%255Bgw_fbsaeid%255D%2526urlfix%253D1%2526adurl%253Dhttps://kampanje.allershopping.no/vhi-4-319-bestikkvase%3Futm_source%3Dbvhi_estikkvase_jul21%26utm_medium%3Dhouse%26utm_campaign%3Dvhi-4-319-bestikkvase',
    cpt: 'document',
    filter: '&clicktag=http'
  },
  {
    url: 'https://delivered-by-madington.com/client/aller/magazine/serve-template?layout=combined&magazine=vhi&bgc=rgb(222,%20222,%20222)&sbgc=rgb(196,%20196,%20196)&cover=&msgBgColor=rgb(255,%20255,%20255)&msgTxtColor=rgb(7,%207,%207)&headerTop=VAKRE%20HJEM%20%26%20INTERI%C3%98R&headerBottom=%2B%20salatbestikk%20og%20vase&magOne=https://delivered-by-madington.com/mess/client-content/uploads/OlInRmpdMK6UlrtWJzln/media/ed49ec04-e89d-408f-9e53-a0db5f1f3872.jpg&magTwo=https://delivered-by-madington.com/mess/client-content/uploads/OlInRmpdMK6UlrtWJzln/media/6e0ab345-511b-47a3-b708-8e29768dd260.jpg&magThree=https://delivered-by-madington.com/mess/client-content/uploads/OlInRmpdMK6UlrtWJzln/media/9110579f-e2bb-4929-b775-e2c53d36f160.jpg&promo=https://delivered-by-madington.com/mess/client-content/uploads/OlInRmpdMK6UlrtWJzln/media/57903f8b-4e3c-4e5d-96c6-bee9a2ac78f9.jpg&tintColor=rgba(17,%208,%208,%200.5)&priceColor=rgb(255,%20255,%20255)&abovePrice=4%20utgaver&price=319%2C-&belowPrice=Spar%20925%2C-&ctaBgColor=rgb(60,%20199,%20166)&ctaBgHoverColor=rgb(52,%20181,%20151)&ctaColor=rgb(255,%20255,%20255)&cta=Abonner%20n%C3%A5!&width=980&height=300&clickTag=https://adclick.g.doubleclick.net/pcs/click%253Fxai%253DAKAOjsuZX1_-cM0MeNB-Yy-Vc_38jvg9ntRhvnS-nYgV79HFKL6cVU9EZEptv5J4tIrX6FZGq44PYnkCIEjuD2ezHnGXqi-WlM1ZmxU_WQJPCvIx_H-ui6MWaUyU-NrwQie0SHbrYo-ON5Iv4haO_PIWfOovD0vHw7_VcnhjNLFt4_4NH1NjOG888yRqxAd3tUfvm7Jldw_y4tDdOMp0v8uYzdqNud6GzHY3SjmUbB3STUDzLv57GhwTzY0aDL7OnyeMglmBu1Hh2wBtXlDuuYjrws3t3yEhqq9Z4iSO_BvZwtoe8a6FUT4orZx47pSkXA%2526sig%253DCg0ArKJSzPMj03LfkVgxEAE%2526fbs_aeid%253D%255Bgw_fbsaeid%255D%2526urlfix%253D1%2526adurl%253Dhttps://kampanje.allershopping.no/vhi-4-319-bestikkvase%3Futm_source%3Dbvhi_estikkvase_jul21%26utm_medium%3Dhouse%26utm_campaign%3Dvhi-4-319-bestikkvase',
    frameUrl: 'https://delivered-by-madington.com/client/aller/magazine/serve-template?layout=combined&magazine=vhi&bgc=rgb(222,%20222,%20222)&sbgc=rgb(196,%20196,%20196)&cover=&msgBgColor=rgb(255,%20255,%20255)&msgTxtColor=rgb(7,%207,%207)&headerTop=VAKRE%20HJEM%20%26%20INTERI%C3%98R&headerBottom=%2B%20salatbestikk%20og%20vase&magOne=https://delivered-by-madington.com/mess/client-content/uploads/OlInRmpdMK6UlrtWJzln/media/ed49ec04-e89d-408f-9e53-a0db5f1f3872.jpg&magTwo=https://delivered-by-madington.com/mess/client-content/uploads/OlInRmpdMK6UlrtWJzln/media/6e0ab345-511b-47a3-b708-8e29768dd260.jpg&magThree=https://delivered-by-madington.com/mess/client-content/uploads/OlInRmpdMK6UlrtWJzln/media/9110579f-e2bb-4929-b775-e2c53d36f160.jpg&promo=https://delivered-by-madington.com/mess/client-content/uploads/OlInRmpdMK6UlrtWJzln/media/57903f8b-4e3c-4e5d-96c6-bee9a2ac78f9.jpg&tintColor=rgba(17,%208,%208,%200.5)&priceColor=rgb(255,%20255,%20255)&abovePrice=4%20utgaver&price=319%2C-&belowPrice=Spar%20925%2C-&ctaBgColor=rgb(60,%20199,%20166)&ctaBgHoverColor=rgb(52,%20181,%20151)&ctaColor=rgb(255,%20255,%20255)&cta=Abonner%20n%C3%A5!&width=980&height=300&clickTag=https://adclick.g.doubleclick.net/pcs/click%253Fxai%253DAKAOjsuZX1_-cM0MeNB-Yy-Vc_38jvg9ntRhvnS-nYgV79HFKL6cVU9EZEptv5J4tIrX6FZGq44PYnkCIEjuD2ezHnGXqi-WlM1ZmxU_WQJPCvIx_H-ui6MWaUyU-NrwQie0SHbrYo-ON5Iv4haO_PIWfOovD0vHw7_VcnhjNLFt4_4NH1NjOG888yRqxAd3tUfvm7Jldw_y4tDdOMp0v8uYzdqNud6GzHY3SjmUbB3STUDzLv57GhwTzY0aDL7OnyeMglmBu1Hh2wBtXlDuuYjrws3t3yEhqq9Z4iSO_BvZwtoe8a6FUT4orZx47pSkXA%2526sig%253DCg0ArKJSzPMj03LfkVgxEAE%2526fbs_aeid%253D%255Bgw_fbsaeid%255D%2526urlfix%253D1%2526adurl%253Dhttps://kampanje.allershopping.no/vhi-4-319-bestikkvase%3Futm_source%3Dbvhi_estikkvase_jul21%26utm_medium%3Dhouse%26utm_campaign%3Dvhi-4-319-bestikkvase',
    cpt: 'image',
    filter: '&clicktag=http'
  },
  {
    url: 'https://geo.moatads.com/n.js?e=35&ol=0&qn=%604%7BZEYwoqI%24%5BK%2BdLLU)%2CMm~tW%2490vv9L%24%2FoDb%2FG)lKr%23l9jmUdTfN%5Bqir1fcSC%3AU%3FWOvTh%7CzFK%3F%5B%22l!j%3F%5DQB3%2ByerEd%5E95SpGl)17*7*7UO0%40M%7CQDt%3ExZq%224%7CQjw%60.%7Bi%3F%5DQZ%2CA2%2BNhloI%40s1%7CZ5*%3FVl%3F%3Bg%3Ch%2BGFK%251R*rV0%2F%60E%60%60Mk%24%26x%5EZE2iD%3DmfxECSR23_hFAkD%3Dv%3CN%5B.%22%24b_o%3FtVD%5D%5BpN%7CQF%40Sy7%7B%2CNr1U*%26ujMUU8fvb%26%22B&th=2469185324&tf=nMzjG---CSa7H-XSSptC-j7VIQD-xFQTS-nMzjG-&vi=111111&rc=0%2C0%2C0%2C0%2C0%2C1%2C0%2C0%2C%2C&rb=1-rjhubJVuFcQVxg%2FZVmjIGjsA6Z6cTHsOS20%3D&sc=1&os=&qp=00000&is=BBBBB2BBEYBvGl2BBCBBtUTE1RmsqbKW8BsrBu0rCFE48CRBeeBS2hWTMBBQeQBBn2soYggyUig0CBlWZ0uBBCCCCCCOgRBBiOfnE6Bkg7Oxib8MxOtJYHCBdm5kBhIcC9Y8oBXckXBR76iUUsJBCBBBBBBBBBWBBBj3BBBZeGV2BBBCMciUBBBjgEBBBBBB94UMgTdJMtEcpMBBBQBBBniOccBBBBBB47kNBBBBBBBBBBBBBhcjG6BBJM2L4Bk8BwCBQmIoRBBCzBz1BBCTClBBrbGBC4ehueB57NG9aJeRzBqEKiuwBBBB&iv=8&qt=0&gz=0&hh=0&hn=0&tw=null&qc=0&qd=0&qf=800&qe=600&qh=800&qg=600&qm=0&qa=800&qb=600&qi=800&qj=600&to=000&po=1-0020002000002120&vy=ot%24b%5Bh%40%22oD%7BMx5%3C1%3B(8.%7CLK2_v%5Eq%2BGs1%7B%2CyB%3AU!%2FoD%7BMx5%3C1%3B(Oy%2CUy%3CD&qr=0&url=https%3A%2F%2Fwww.espn.com%2Fnba-summer-league%2Fgame%2F_%2FgameId%2F401352154%2Fleague%2Fnba-summer-las-vegas&pcode=espnprebidheader738072710622&ql=&qo=0&i=ESPN1&hp=1&wf=1&ra=1&pxm=3&sgs=3&vb=3&cm=16&kq=1&hq=0&hs=0&hu=0&hr=0&ht=0&dnt=0&bq=0&f=0&j=&t=1628627858810&de=691686819&m=0&ar=4790001-clean&iw=fe97f48&q=3&cb=0&ym=0&cu=1628627858810&ll=2&lm=0&ln=1&r=0&em=0&en=0&d=4740346008%3A2854600074%3A5685048460%3A138349338466&zMoatPS=banner&zMoatSW=20BBE03A-7734-484B-C88A-0ADFADAE5E4A&zMoatSZ=728x90&zMoatOrigSlicer1=21782482296&zMoatOrigSlicer2=21828916465&zMoatMMV_MAX=waiting&zMoatMMV=waiting&zMoatMGV=waiting&zMoatMSafety=waiting&zMoatMData=waiting&zMoatCURL=espn.com%2Fnba-summer-league%2Fgame%2F_%2FgameId%2F401352154%2Fleague%2Fnba-summer-las-vegas&zMoatDev=Desktop&zGSRS=1&zGSRC=1&gu=https%3A%2F%2Fwww.espn.com%2Fnba-summer-league%2Fgame%2F_%2FgameId%2F401352154%2Fleague%2Fnba-summer-las-vegas&id=1&ii=4&bo=21782482296&bd=21828916465&dfp=0%2C1&la=21828916465&gw=espndfp832188684382&fd=1&ac=1&it=500&ti=0&ih=1&pe=1%3A575%3A680%3A0%3A947&iq=waiting&tt=waiting&tu=waiting&tp=waiting&fs=193790&na=11507536&cs=0&callback=MoatDataJsonpRequest_44791471',
    frameUrl: 'https://www.espn.com/nba-summer-league/game/_/gameId/401352154/league/nba-summer-las-vegas',
    cpt: 'script',
    filter: '=728x90&'
  }
]

I've included the filter that Adblock Plus matches.

@mjethani
Copy link
Contributor

@remusao same as above for Cliqz:

[
  {
    url: 'https://www.google-analytics.com/j/collect?v=1&_v=j92&a=393452224&t=pageview&_s=1&dl=https%3A%2F%2Fthechive.com%2F&ul=en-us&de=UTF-8&dt=An%20improbable%20hall%20of%20fame%20journey%20and%20the%201.000%20batting%20average%20(8%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Actors%20you%20WON%E2%80%99T%20BELIEVE%20are%20turning%2060%20this%20year%20(16%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Animals%20prove%20you%20can%20find%20friends%20in%20the%20most%20unlikely%20of%20places%20(22%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09A%20Bikini%20a%20day%20keeps%20the%20Bikini%20Doctor%20away%E2%80%A6%20right%3F%20(35%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Daily%20Morning%20Awesomeness%20(40%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Turns%20out%20marriage%20is%20a%20big%20f%40%23%25ing%20joke%20(31%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Kids%20bring%20some%20crazy%20sh*t%20to%20show%20and%20tell%20(19%20GIFs)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Blazing%20hot%20Dutch%20runner%20Lieke%20Klaver%20won%20the%20Olympics%20(21%20photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Quentin%20Tarantino%20explains%20why%20he%E2%80%99ll%20NEVER%20give%20his%20mom%20a%20cent%20of%20his%20film%20money%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Daily%20Afternoon%20Randomness%20(49%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Keep%20calm%20and%20tug%20on%20(38%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Some%20small%20hills%20are%20worth%20dying%20on%2C%20just%20ask%20these%20folks%20(20%20GIFs)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09The%20best%20tweets%20from%20parents%20of%20all%20time%20last%20week%20(25%20photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Folks%20share%20memories%20of%20their%20fathers%20who%20passed%20away%20(21%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Daily%20Morning%20Awesomeness%20(38%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09What%E2%80%99s%20the%20Worst%20Pain%20You%E2%80%99ve%20Ever%20Felt%3F%20(15%20GIFs)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09All%20systems%20GO!%20Prepare%20for%20Liftoff%20in%203%E2%80%A62%E2%80%A61%E2%80%A6%20(45%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Read%20Between%20the%20Tan%20Lines%20(35%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09My%20sweet%20Big%20Mouth%20Billy%20Bass%2C%20look%20what%20they%20did%20to%20you!%20(Video)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Weekend%20Afternoon%20Randomness%20(36%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09GIFs%20prove%3A%20Can%E2%80%99t%20out-Random%20the%20internet%20(25%20GIFs)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09These%20male%20authors%20prove%20they%20know%20nothing%20about%20women%E2%80%99s%20bodies%20(31%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Nice%20Design%20Work%20Ya%20Absolute%20Prick!%20(23%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Upon%20closer%20inspection%20HOLY%20S***!%20(35%20Photos)%09%09%09%0A%09%09%0A%09%09%09%0A%09%09%09%09Weekend%20Morning%20Awesomeness%20(37%20photos)&sd=24-bit&sr=800x600&vp=800x600&je=0&_u=YEBAAAABAAAAAC~&jid=331000972&gjid=1930197999&cid=827252379.1628628622&tid=UA-6481362-1&_gid=1175243576.1628628622&_r=1&gtm=2wg891P83WPK&cg2=homepage&cd2=&cd3=homepage&cd4=&cd5=&cd13=C_JS%3A%5Bobject%20Object%5Dundefined%2CmetaId%3Ano%2CbodyPostId%3Ano&z=388502388',
    frameUrl: 'https://thechive.com/',
    cpt: 'xhr',
    filter: '/collect?*&cid='
  },
  {
    url: 'https://src.ebay-us.com/800u3jujhrtna4oy.js?t2h0syoxz29o70at=usllpic0&m4g3fbcsoflgkza2=31ceded617b0a69c2824c2d9fffd7bf3',
    frameUrl: 'https://pages.ebay.com/identity/device/t_n6.html?org_id=usllpic0&session_id=31ceded617b0a69c2824c2d9fffd7bf3',
    cpt: 'script',
    filter: '||src.ebay-us.com/*=usllpic$script,domain=ebay.com'
  },
  {
    url: 'https://src.ebay-us.com/ogt03wuuyq02o439.js?b0ng6y3956rv7z5l=usllpic0&p92vm2xpizpewx4q=31c65d0317b0a770e5eefd4ffffce40c',
    frameUrl: 'https://pages.ebay.com/identity/device/t_n6.html?org_id=usllpic0&session_id=31c65d0317b0a770e5eefd4ffffce40c',
    cpt: 'script',
    filter: '||src.ebay-us.com/*=usllpic$script,domain=ebay.com'
  },
  {
    url: 'https://src.ebay-us.com/hwmad1apj64n3dpx.js?ugs0m7pwid2lkdh5=usllpic0&4xe1mk1zhq54nvk7=31c6677517b0acf066401d61fffdca35',
    frameUrl: 'https://pages.ebay.com/identity/device/t_n6.html?org_id=usllpic0&session_id=31c6677517b0acf066401d61fffdca35',
    cpt: 'script',
    filter: '||src.ebay-us.com/*=usllpic$script,domain=ebay.com'
  },
  {
    url: 'https://src.ebay-us.com/gkcqo9woje6b22wb.js?uotokwwa26hnv3n3=usllpic0&ggrewltfacjqqswc=31c6919417b0a770463e7659fffd1f75',
    frameUrl: 'https://pages.ebay.com/identity/device/t_n6.html?org_id=usllpic0&session_id=31c6919417b0a770463e7659fffd1f75',
    cpt: 'script',
    filter: '||src.ebay-us.com/*=usllpic$script,domain=ebay.com'
  },
  {
    url: 'https://src.ebay-us.com/acayc2ovn9r4q8uf.js?ykei92uevqwds9ca=usllpic0&ti08yepck3nud6l9=31c850b917b0addd8d576ddbfffe417d',
    frameUrl: 'https://pages.ebay.com/identity/device/t_n6.html?org_id=usllpic0&session_id=31c850b917b0addd8d576ddbfffe417d',
    cpt: 'script',
    filter: '||src.ebay-us.com/*=usllpic$script,domain=ebay.com'
  },
  {
    url: 'https://www.google-analytics.com/j/collect?v=1&_v=j92&a=1523452421&t=event&ni=1&qt=0&_s=1&dl=https%3A%2F%2Fwww.lifewire.com%2F&dr=&dp=%2F&ul=en-us&de=UTF-8&dt=Lifewire%3A%20Tech%20News%2C%20Reviews%2C%20Help%20%26%20How-Tos&sd=24-bit&sr=800x600&vp=800x600&je=0&ec=AB%20Tests&ea=Map%20Vertical%20Proctor%20Data&el=%7B%2253%22%3A%22rightRailOffset%20%7C%20active%20%7C%20active%20-%20Move%20right-rail__offset%20to%20content%20well%20%7C%201%22%2C%2257%22%3A%22journeysNextUp%20%7C%20version4%20%7C%20Version%204%20%7C%204%22%2C%2264%22%3A%22railVideoMargin%20%7C%20control%20%7C%20Keep%20intersection%20margin%20at%20250px%20%7C%200%22%2C%2275%22%3A%22pageViewEventLoaded%20%7C%20delay%20%7C%20Page%20View%20triggered%20on%20Document%20Load%20%7C%201%22%2C%2278%22%3A%22featuredLinkExternal%20%7C%20buttonNew%20%7C%20Button%20new%20style%20%7C%202%22%2C%2299-0%22%3A%22includeIAS%20%7C%20includeIAS%20%7C%20Include%20IAS%20script%20%7C%201%22%2C%2299-1%22%3A%22mediaGrid%20%7C%20active%20%7C%20active%20%7C%201%22%2C%2299-2%22%3A%22mapFBValues%20%7C%20hasFBMap%20%7C%20Using%20the%20FB%20map%20values%20%7C%201%22%2C%2299-3%22%3A%22pageLoadDesktopT4%20%7C%20control%20%7C%20Control%20(lazy-load)%20%7C%200%22%2C%2299-4%22%3A%22rtbBiddingLatencyBuffer%20%7C%20control%20%7C%20control%20%7C%200%22%2C%2299-5%22%3A%22scMobileAdPositions%20%7C%20control%20%7C%20Control%20%7C%200%22%2C%2299-6%22%3A%22scDesktopAdPositions%20%7C%20control%20%7C%20control%20%7C%200%22%2C%2299-7%22%3A%22leaderboardacOffset%20%7C%20control%20%7C%20Control%20(default%20offset%20of%20400)%20%7C%200%22%2C%2299-8%22%3A%22cmpTimeout%20%7C%20t1%20%7C%20Test%201%20%7C%201%22%2C%2299-9%22%3A%22pbTeads%20%7C%20teads%20%7C%20Teads%20%7C%201%22%2C%2299-10%22%3A%22prebid%20%7C%20ixId%20%7C%20Active%20with%20index%20identity%20adapter%20%7C%202%22%2C%2299-12%22%3A%22cssJsInjection%20%7C%20control%20%7C%20Control%20(no%20change)%20%7C%200%22%2C%2299-13%22%3A%22rtbTimeout%20%7C%20test2%20%7C%20test2%20%7C%202%22%2C%2299-14%22%3A%22commerceButtonOptimization_text%20%7C%20control%20%7C%20control%20%7C%200%22%2C%2299-15%22%3A%22cssJsInjection_tmobiletest%20%7C%20control%20%7C%20control%20%7C%200%22%2C%2299-20%22%3A%22useRTBforVideoAds%20%7C%20control%20%7C%20%7C%200%22%7D&_u=YEBAAUABAAAAAC~&jid=1097827104&gjid=278702358&cid=1501590216.1628628774&tid=UA-44417706-3&_gid=27435473.1628628774&_r=1&gtm=2wg8915P3SZGS&cd13=GTM-5P3SZGS&cd14=43&cd42=Mozilla%2F5.0%20(X11%3B%20Linux%20x86_64)%20AppleWebKit%2F537.36%20(KHTML%2C%20like%20Gecko)%20HeadlessChrome%2F93.0.4577.0%20Safari%2F537.36&cd46=%7B%22robots%22%3A%22max-image-preview%3Alarge%2C%20NOODP%2C%20NOYDIR%22%2C%22fb%3Aapp_id%22%3A%221833670990199396%22%7D&cd48=Direct&cd53=rightRailOffset%20%7C%20active%20%7C%20active%20-%20Move%20right-rail__offset%20to%20content%20well%20%7C%201&cd57=journeysNextUp%20%7C%20version4%20%7C%20Version%204%20%7C%204&cd64=railVideoMargin%20%7C%20control%20%7C%20Keep%20intersection%20margin%20at%20250px%20%7C%200&cd75=pageViewEventLoaded%20%7C%20delay%20%7C%20Page%20View%20triggered%20on%20Document%20Load%20%7C%201&cd78=featuredLinkExternal%20%7C%20buttonNew%20%7C%20Button%20new%20style%20%7C%202&z=1164935443',
    frameUrl: 'https://www.lifewire.com/',
    cpt: 'xhr',
    filter: '/collect?*&cid='
  },
  {
    url: 'https://src.ebay-us.com/93pchd9jjazbx1mf.js?ulmpfvmebou1uhdn=usllpic0&t7lbneicj2p7pe7b=31c83afd17b0acb47847ed87fffcdeee',
    frameUrl: 'https://pages.ebay.com/identity/device/t_n6.html?org_id=usllpic0&session_id=31c83afd17b0acb47847ed87fffcdeee',
    cpt: 'script',
    filter: '||src.ebay-us.com/*=usllpic$script,domain=ebay.com'
  },
  {
    url: 'https://src.ebay-us.com/ofc8lb2zw9xlwgan.js?8kkzfaannqhvf4w3=usllpic0&3ovsbiogi5cyl9c9=31ceb2d517b0a45e36136c3cfffba69d',
    frameUrl: 'https://pages.ebay.com/identity/device/t_n6.html?org_id=usllpic0&session_id=31ceb2d517b0a45e36136c3cfffba69d',
    cpt: 'script',
    filter: '||src.ebay-us.com/*=usllpic$script,domain=ebay.com'
  }
]

@mjethani
Copy link
Contributor

@antonok-edm Brave appears to have a problem blocking these

@remusao same as above for Cliqz

Note that we need to apply #2154 for the above as well as for the results below.

@ameshkov for tsurlfilter there are 35 false negatives:

[
  {
    url: 'https://sams.spiegel.de/id?d_visid_ver=5.2.0&d_fieldgroup=A&mcorgid=79655FCF5C1D42160A495E15%40AdobeOrg&mid=16836366873838520273040683356840932679&d_coppa=true&ts=1628627559223',
    frameUrl: 'https://www.spiegel.de/consent-a-?targetUrl=https%3A%2F%2Fwww.spiegel.de%2F',
    cpt: 'xhr',
    filter: '||sams.spiegel.de^'
  },
  {
    url: 'https://assets.adobedtm.com/extensions/EPbde2f7ca14e540399dcc1f8208860b7b/AppMeasurement.min.js',
    frameUrl: 'https://www.spiegel.de/consent-a-?targetUrl=https%3A%2F%2Fwww.spiegel.de%2F',
    cpt: 'script',
    filter: '||adobedtm.com^$third-party,domain=~adobe.com'
  },
  {
    url: 'https://assets.adobedtm.com/extensions/EPbde2f7ca14e540399dcc1f8208860b7b/AppMeasurement_Module_ActivityMap.min.js',
    frameUrl: 'https://www.spiegel.de/consent-a-?targetUrl=https%3A%2F%2Fwww.spiegel.de%2F',
    cpt: 'script',
    filter: '||adobedtm.com^$third-party,domain=~adobe.com'
  },
  {
    url: 'https://assets.adobedtm.com/extensions/EPbde2f7ca14e540399dcc1f8208860b7b/AppMeasurement_Module_AudienceManagement.min.js',
    frameUrl: 'https://www.spiegel.de/consent-a-?targetUrl=https%3A%2F%2Fwww.spiegel.de%2F',
    cpt: 'script',
    filter: '||adobedtm.com^$third-party,domain=~adobe.com'
  },
  {
    url: 'https://assets.adobedtm.com/cc10f7b4369d/cb3b620b1166/a72875a13608/RC632cb38759ad472ebbbb59c275c8012f-source.min.js',
    frameUrl: 'https://www.spiegel.de/consent-a-?targetUrl=https%3A%2F%2Fwww.spiegel.de%2F',
    cpt: 'script',
    filter: '||adobedtm.com^$third-party,domain=~adobe.com'
  },
  {
    url: 'https://assets.adobedtm.com/cc10f7b4369d/cb3b620b1166/a72875a13608/RCcfc820923efc4227abb9cb9473206938-source.min.js',
    frameUrl: 'https://www.spiegel.de/consent-a-?targetUrl=https%3A%2F%2Fwww.spiegel.de%2F',
    cpt: 'script',
    filter: '||adobedtm.com^$third-party,domain=~adobe.com'
  },
  {
    url: 'https://assets.adobedtm.com/cc10f7b4369d/cb3b620b1166/a72875a13608/RC2cba00dae0e34354a60748ab919d7542-source.min.js',
    frameUrl: 'https://www.spiegel.de/consent-a-?targetUrl=https%3A%2F%2Fwww.spiegel.de%2F',
    cpt: 'script',
    filter: '||adobedtm.com^$third-party,domain=~adobe.com'
  },
  {
    url: 'https://assets.adobedtm.com/cc10f7b4369d/cb3b620b1166/a72875a13608/RC046ffdc034714f47aa00e06a2b76efd6-source.min.js',
    frameUrl: 'https://www.spiegel.de/consent-a-?targetUrl=https%3A%2F%2Fwww.spiegel.de%2F',
    cpt: 'script',
    filter: '||adobedtm.com^$third-party,domain=~adobe.com'
  },
  {
    url: 'https://assets.adobedtm.com/cc10f7b4369d/cb3b620b1166/a72875a13608/RC862020349d4e4d60bfa847eb35924fc7-source.min.js',
    frameUrl: 'https://www.spiegel.de/consent-a-?targetUrl=https%3A%2F%2Fwww.spiegel.de%2F',
    cpt: 'script',
    filter: '||adobedtm.com^$third-party,domain=~adobe.com'
  },
  {
    url: 'https://sams.spiegel.de/b/ss/spiegel.ng.spieg.main/10/JS-2.22.0-LBSQ/s88670449890817?AQB=1&ndh=1&pf=1&callback=s_c_il[1].doPostbacks&et=1&t=10%2F7%2F2021%2020%3A32%3A39%202%200&d.&nsid=0&jsonv=1&.d&mid=16836366873838520273040683356840932679&ce=UTF-8&pageName=sp.www%20%3E%20consent%20%3E%20%2Fconsent-a-&g=https%3A%2F%2Fwww.spiegel.de%2Fconsent-a-&r=https%3A%2F%2Fwww.spiegel.de%2F&c.&getPreviousValue=3.0&inList=3.0&apl=4.0&getValOnce=3.0&p_fo=3.0&getQueryParam=4.0.1&pt=3.0&cm.&ssf=1&.cm&opt.&sell=N&.opt&.c&cc=EUR&ch=consent-a-&server=www.spiegel.de&events=event2%2Cevent1&c1=sp.www%20%3E%20consent%20%3E%20%2Fconsent-a-&v1=D%3DpageName&h1=sp%7Cwww%7Cconsent-a-%7Cconsent&c2=from_int_homepage&v2=https%3A%2F%2Fwww.spiegel.de%2Fconsent-a-&h2=www.spiegel.de%7Cconsent-a-%7C%7C&v3=web&v4=consent&v5=consent&c7=from_int_homepage&v7=Consent&v8=www.spiegel.de&c9=%2Fconsent-a-&v9=%3FtargetUrl%3Dhttps%253A%252F%252Fwww.spiegel.de%252F&v11=www.spiegel.de&c12=D%3Dpid&v12=https%3A%2F%2Fwww.spiegel.de%2F&v15=D%3Dc2&v16=pure_tracking&v18=https%3A%2F%2Fwww.spiegel.de%2Fconsent-a-&v19=https%3A%2F%2Fwww.spiegel.de%2F&c32=2021-08-10T20%3A32%3A39.557Z&v33=desktop&v35=22%3A32&v36=new_visitor&v38=1.d%3A1.v%7C0.x%3A0.x&v40=visible&c50=event2%2Cevent1&c55=1628627558&c60=no_emetriqID&c61=has_visitorAPI&c62=no_ssoID&c65=undefined&c70=default&c71=page_data_ready%7Cgeneric%7C&c72=spiegel%3A%3A__01_dbrsowftuk_backstage%2Fconsent&c73=01_a_spiegel.de_NextGen%7C27.1.3%7C2021-04-26T16%3A54%3A28Z&c74=production%7C2021-08-10T12%3A45%3A02Z&c75=v1.7.23&v147=D%3Dv0&v148=D%3Dv145&v149=D%3Dv146&v175=logged_out&v177=no_paidAccess&v178=has_conditionalAccess&v179=no_noAdsAccess&v185=D%3Dmid&v200=D%3DUser-Agent&s=800x600&c=24&j=1.6&v=N&k=Y&bw=800&bh=600&mcorgid=79655FCF5C1D42160A495E15%40AdobeOrg&AQE=1',
    frameUrl: 'https://www.spiegel.de/consent-a-?targetUrl=https%3A%2F%2Fwww.spiegel.de%2F',
    cpt: 'script',
    filter: '||sams.spiegel.de^'
  },
  {
    url: 'https://frog.wix.com/fed',
    frameUrl: 'https://www.deviantart.com/asur-misoa/art/The-Otherworld-Banner-882754323',
    cpt: 'ping',
    filter: '||frog.wix.com^$ping,xmlhttprequest'
  },
  {
    url: 'https://frog.wix.com/fed',
    frameUrl: 'https://www.deviantart.com/fotografka/art/Cake-575010606',
    cpt: 'ping',
    filter: '||frog.wix.com^$ping,xmlhttprequest'
  },
  {
    url: 'https://frog.wix.com/fed',
    frameUrl: 'https://www.deviantart.com/fotografka/art/Cake-575010606',
    cpt: 'ping',
    filter: '||frog.wix.com^$ping,xmlhttprequest'
  },
  {
    url: 'https://assets.adobedtm.com/extensions/EPbde2f7ca14e540399dcc1f8208860b7b/AppMeasurement.min.js',
    frameUrl: 'https://www.spiegel.de/datenschutz-spiegel',
    cpt: 'script',
    filter: '||adobedtm.com^$third-party,domain=~adobe.com'
  },
  {
    url: 'https://assets.adobedtm.com/extensions/EPbde2f7ca14e540399dcc1f8208860b7b/AppMeasurement_Module_ActivityMap.min.js',
    frameUrl: 'https://www.spiegel.de/datenschutz-spiegel',
    cpt: 'script',
    filter: '||adobedtm.com^$third-party,domain=~adobe.com'
  },
  {
    url: 'https://assets.adobedtm.com/extensions/EPbde2f7ca14e540399dcc1f8208860b7b/AppMeasurement_Module_AudienceManagement.min.js',
    frameUrl: 'https://www.spiegel.de/datenschutz-spiegel',
    cpt: 'script',
    filter: '||adobedtm.com^$third-party,domain=~adobe.com'
  },
  {
    url: 'https://assets.adobedtm.com/cc10f7b4369d/cb3b620b1166/a72875a13608/RC632cb38759ad472ebbbb59c275c8012f-source.min.js',
    frameUrl: 'https://www.spiegel.de/datenschutz-spiegel',
    cpt: 'script',
    filter: '||adobedtm.com^$third-party,domain=~adobe.com'
  },
  {
    url: 'https://assets.adobedtm.com/cc10f7b4369d/cb3b620b1166/a72875a13608/RC862020349d4e4d60bfa847eb35924fc7-source.min.js',
    frameUrl: 'https://www.spiegel.de/datenschutz-spiegel',
    cpt: 'script',
    filter: '||adobedtm.com^$third-party,domain=~adobe.com'
  },
  {
    url: 'https://sams.spiegel.de/b/ss/spiegel.ng.spieg.main/10/JS-2.22.0-LBSQ/s8443027824172?AQB=1&ndh=1&pf=1&callback=s_c_il[1].doPostbacks&et=1&t=10%2F7%2F2021%2020%3A32%3A44%202%200&d.&nsid=0&jsonv=1&.d&mid=16836366873838520273040683356840932679&ce=UTF-8&pageName=sp.www%20%3E%20page%20%3E%20%2Fdatenschutz-spiegel&g=https%3A%2F%2Fwww.spiegel.de%2Fdatenschutz-spiegel&c.&getPreviousValue=3.0&inList=3.0&apl=4.0&getValOnce=3.0&p_fo=3.0&getQueryParam=4.0.1&pt=3.0&cm.&ssf=1&.cm&opt.&sell=N&.opt&.c&cc=EUR&ch=datenschutz-spiegel&server=www.spiegel.de&events=event1&c1=sp.www%20%3E%20page%20%3E%20%2Fdatenschutz-spiegel&v1=D%3DpageName&h1=sp%7Cwww%7Cdatenschutz-spiegel%7Cpage&c2=from_nocat_nodef&v2=https%3A%2F%2Fwww.spiegel.de%2Fdatenschutz-spiegel&h2=www.spiegel.de%7Cdatenschutz-spiegel%7C%7C&v3=web&v4=page&v5=page&c7=from_nocat_nodef&v7=So%20gehen%20wir%20mit%20Ihren%20Daten%20um&v8=www.spiegel.de&c9=%2Fdatenschutz-spiegel&c12=D%3Dpid&v13=sp.www%20%3E%20consent%20%3E%20%2Fconsent-a-&v15=D%3Dc2&v16=pure_tracking&v18=https%3A%2F%2Fwww.spiegel.de%2Fdatenschutz-spiegel&c32=2021-08-10T20%3A32%3A44.620Z&v33=desktop&v35=22%3A32&v36=return_visitor&v38=1.f%3A4.f%7C0.x%3A0.x&v40=visible&c50=event1&c55=1628627564&c60=no_emetriqID&c61=has_visitorAPI&c62=no_ssoID&c65=undefined&c70=default&c71=page_data_ready%7Cgeneric%7C&c73=01_a_spiegel.de_NextGen%7C27.1.3%7C2021-04-26T16%3A54%3A28Z&c74=production%7C2021-08-10T12%3A45%3A02Z&c75=v1.7.23&v147=D%3Dv0&v148=D%3Dv145&v149=D%3Dv146&v175=logged_out&v177=no_paidAccess&v178=has_conditionalAccess&v179=no_noAdsAccess&v185=D%3Dmid&v200=D%3DUser-Agent&s=800x600&c=24&j=1.6&v=N&k=Y&bw=800&bh=600&mcorgid=79655FCF5C1D42160A495E15%40AdobeOrg&AQE=1',
    frameUrl: 'https://www.spiegel.de/datenschutz-spiegel',
    cpt: 'script',
    filter: '||sams.spiegel.de^'
  },
  {
    url: 'https://frog.wix.com/fed',
    frameUrl: 'https://www.deviantart.com/',
    cpt: 'ping',
    filter: '||frog.wix.com^$ping,xmlhttprequest'
  },
  {
    url: 'https://assets.adobedtm.com/extensions/EPbde2f7ca14e540399dcc1f8208860b7b/AppMeasurement.min.js',
    frameUrl: 'https://www.spiegel.de/how-we-deal-with-your-data',
    cpt: 'script',
    filter: '||adobedtm.com^$third-party,domain=~adobe.com'
  },
  {
    url: 'https://assets.adobedtm.com/extensions/EPbde2f7ca14e540399dcc1f8208860b7b/AppMeasurement_Module_ActivityMap.min.js',
    frameUrl: 'https://www.spiegel.de/how-we-deal-with-your-data',
    cpt: 'script',
    filter: '||adobedtm.com^$third-party,domain=~adobe.com'
  },
  {
    url: 'https://assets.adobedtm.com/extensions/EPbde2f7ca14e540399dcc1f8208860b7b/AppMeasurement_Module_AudienceManagement.min.js',
    frameUrl: 'https://www.spiegel.de/how-we-deal-with-your-data',
    cpt: 'script',
    filter: '||adobedtm.com^$third-party,domain=~adobe.com'
  },
  {
    url: 'https://assets.adobedtm.com/cc10f7b4369d/cb3b620b1166/a72875a13608/RC632cb38759ad472ebbbb59c275c8012f-source.min.js',
    frameUrl: 'https://www.spiegel.de/how-we-deal-with-your-data',
    cpt: 'script',
    filter: '||adobedtm.com^$third-party,domain=~adobe.com'
  },
  {
    url: 'https://assets.adobedtm.com/cc10f7b4369d/cb3b620b1166/a72875a13608/RC862020349d4e4d60bfa847eb35924fc7-source.min.js',
    frameUrl: 'https://www.spiegel.de/how-we-deal-with-your-data',
    cpt: 'script',
    filter: '||adobedtm.com^$third-party,domain=~adobe.com'
  },
  {
    url: 'https://sams.spiegel.de/b/ss/spiegel.ng.spieg.main/10/JS-2.22.0-LBSQ/s87108944940159?AQB=1&ndh=1&pf=1&callback=s_c_il[1].doPostbacks&et=1&t=10%2F7%2F2021%2020%3A32%3A41%202%200&d.&nsid=0&jsonv=1&.d&mid=16836366873838520273040683356840932679&ce=UTF-8&pageName=sp.www%20%3E%20page%20%3E%20%2Fhow-we-deal-with-your-data&g=https%3A%2F%2Fwww.spiegel.de%2Fhow-we-deal-with-your-data&c.&getPreviousValue=3.0&inList=3.0&apl=4.0&getValOnce=3.0&p_fo=3.0&getQueryParam=4.0.1&pt=3.0&cm.&ssf=1&.cm&opt.&sell=N&.opt&.c&cc=EUR&ch=how-we-deal-with-your-data&server=www.spiegel.de&events=event1&c1=sp.www%20%3E%20page%20%3E%20%2Fhow-we-deal-with-your-data&v1=D%3DpageName&h1=sp%7Cwww%7Chow-we-deal-with-your-data%7Cpage&c2=from_nocat_nodef&v2=https%3A%2F%2Fwww.spiegel.de%2Fhow-we-deal-with-your-data&h2=www.spiegel.de%7Chow-we-deal-with-your-data%7C%7C&v3=web&v4=page&v5=page&c7=from_nocat_nodef&v7=How%20we%20deal%20with%20your%20data&v8=www.spiegel.de&c9=%2Fhow-we-deal-with-your-data&c12=D%3Dpid&v13=sp.www%20%3E%20consent%20%3E%20%2Fconsent-a-&v15=D%3Dc2&v16=pure_tracking&v18=https%3A%2F%2Fwww.spiegel.de%2Fhow-we-deal-with-your-data&c32=2021-08-10T20%3A32%3A41.157Z&v33=desktop&v35=22%3A32&v36=return_visitor&v38=1.f%3A2.f%7C0.x%3A0.x&v40=visible&c50=event1&c55=1628627560&c60=no_emetriqID&c61=has_visitorAPI&c62=no_ssoID&c65=undefined&c70=default&c71=page_data_ready%7Cgeneric%7C&c73=01_a_spiegel.de_NextGen%7C27.1.3%7C2021-04-26T16%3A54%3A28Z&c74=production%7C2021-08-10T12%3A45%3A02Z&c75=v1.7.23&v147=D%3Dv0&v148=D%3Dv145&v149=D%3Dv146&v175=logged_out&v177=no_paidAccess&v178=has_conditionalAccess&v179=no_noAdsAccess&v185=D%3Dmid&v200=D%3DUser-Agent&s=800x600&c=24&j=1.6&v=N&k=Y&bw=800&bh=600&mcorgid=79655FCF5C1D42160A495E15%40AdobeOrg&AQE=1',
    frameUrl: 'https://www.spiegel.de/how-we-deal-with-your-data',
    cpt: 'script',
    filter: '||sams.spiegel.de^'
  },
  {
    url: 'https://frog.wix.com/fed',
    frameUrl: 'https://www.deviantart.com/fotografka/art/Cake-575010606#comments',
    cpt: 'ping',
    filter: '||frog.wix.com^$ping,xmlhttprequest'
  },
  {
    url: 'https://assets.adobedtm.com/extensions/EPbde2f7ca14e540399dcc1f8208860b7b/AppMeasurement.min.js',
    frameUrl: 'https://www.spiegel.de/consent-a-?targetUrl=https%3A%2F%2Fwww.spiegel.de%2F',
    cpt: 'script',
    filter: '||adobedtm.com^$third-party,domain=~adobe.com'
  },
  {
    url: 'https://assets.adobedtm.com/extensions/EPbde2f7ca14e540399dcc1f8208860b7b/AppMeasurement_Module_ActivityMap.min.js',
    frameUrl: 'https://www.spiegel.de/consent-a-?targetUrl=https%3A%2F%2Fwww.spiegel.de%2F',
    cpt: 'script',
    filter: '||adobedtm.com^$third-party,domain=~adobe.com'
  },
  {
    url: 'https://assets.adobedtm.com/extensions/EPbde2f7ca14e540399dcc1f8208860b7b/AppMeasurement_Module_AudienceManagement.min.js',
    frameUrl: 'https://www.spiegel.de/consent-a-?targetUrl=https%3A%2F%2Fwww.spiegel.de%2F',
    cpt: 'script',
    filter: '||adobedtm.com^$third-party,domain=~adobe.com'
  },
  {
    url: 'https://assets.adobedtm.com/cc10f7b4369d/cb3b620b1166/a72875a13608/RC632cb38759ad472ebbbb59c275c8012f-source.min.js',
    frameUrl: 'https://www.spiegel.de/consent-a-?targetUrl=https%3A%2F%2Fwww.spiegel.de%2F',
    cpt: 'script',
    filter: '||adobedtm.com^$third-party,domain=~adobe.com'
  },
  {
    url: 'https://assets.adobedtm.com/cc10f7b4369d/cb3b620b1166/a72875a13608/RCcfc820923efc4227abb9cb9473206938-source.min.js',
    frameUrl: 'https://www.spiegel.de/consent-a-?targetUrl=https%3A%2F%2Fwww.spiegel.de%2F',
    cpt: 'script',
    filter: '||adobedtm.com^$third-party,domain=~adobe.com'
  },
  {
    url: 'https://assets.adobedtm.com/cc10f7b4369d/cb3b620b1166/a72875a13608/RC2cba00dae0e34354a60748ab919d7542-source.min.js',
    frameUrl: 'https://www.spiegel.de/consent-a-?targetUrl=https%3A%2F%2Fwww.spiegel.de%2F',
    cpt: 'script',
    filter: '||adobedtm.com^$third-party,domain=~adobe.com'
  },
  {
    url: 'https://assets.adobedtm.com/cc10f7b4369d/cb3b620b1166/a72875a13608/RC862020349d4e4d60bfa847eb35924fc7-source.min.js',
    frameUrl: 'https://www.spiegel.de/consent-a-?targetUrl=https%3A%2F%2Fwww.spiegel.de%2F',
    cpt: 'script',
    filter: '||adobedtm.com^$third-party,domain=~adobe.com'
  },
  {
    url: 'https://sams.spiegel.de/b/ss/spiegel.ng.spieg.main/10/JS-2.22.0-LBSQ/s87811574487383?AQB=1&ndh=1&pf=1&callback=s_c_il[1].doPostbacks&et=1&t=10%2F7%2F2021%2020%3A32%3A43%202%200&d.&nsid=0&jsonv=1&.d&mid=16836366873838520273040683356840932679&ce=UTF-8&pageName=sp.www%20%3E%20consent%20%3E%20%2Fconsent-a-&g=https%3A%2F%2Fwww.spiegel.de%2Fconsent-a-&r=https%3A%2F%2Fwww.spiegel.de%2F&c.&getPreviousValue=3.0&inList=3.0&apl=4.0&getValOnce=3.0&p_fo=3.0&getQueryParam=4.0.1&pt=3.0&cm.&ssf=1&.cm&opt.&sell=N&.opt&.c&cc=EUR&ch=consent-a-&server=www.spiegel.de&events=event2%2Cevent1&c1=sp.www%20%3E%20consent%20%3E%20%2Fconsent-a-&v1=D%3DpageName&h1=sp%7Cwww%7Cconsent-a-%7Cconsent&c2=from_int_homepage&v2=https%3A%2F%2Fwww.spiegel.de%2Fconsent-a-&h2=www.spiegel.de%7Cconsent-a-%7C%7C&v3=web&v4=consent&v5=consent&c7=from_int_homepage&v7=Consent&v8=www.spiegel.de&c9=%2Fconsent-a-&v9=%3FtargetUrl%3Dhttps%253A%252F%252Fwww.spiegel.de%252F&v11=www.spiegel.de&c12=D%3Dpid&v12=https%3A%2F%2Fwww.spiegel.de%2F&v13=sp.www%20%3E%20page%20%3E%20%2Fhow-we-deal-with-your-data&v15=D%3Dc2&v16=pure_tracking&v18=https%3A%2F%2Fwww.spiegel.de%2Fconsent-a-&v19=https%3A%2F%2Fwww.spiegel.de%2F&c32=2021-08-10T20%3A32%3A43.019Z&v33=desktop&v35=22%3A32&v36=return_visitor&v38=1.f%3A3.f%7C0.x%3A0.x&v40=visible&c50=event2%2Cevent1&c55=1628627562&c60=no_emetriqID&c61=has_visitorAPI&c62=no_ssoID&c65=undefined&c70=default&c71=page_data_ready%7Cgeneric%7C&c72=spiegel%3A%3A__01_dbrsowftuk_backstage%2Fconsent&c73=01_a_spiegel.de_NextGen%7C27.1.3%7C2021-04-26T16%3A54%3A28Z&c74=production%7C2021-08-10T12%3A45%3A02Z&c75=v1.7.23&v147=D%3Dv0&v148=D%3Dv145&v149=D%3Dv146&v175=logged_out&v177=no_paidAccess&v178=has_conditionalAccess&v179=no_noAdsAccess&v185=D%3Dmid&v200=D%3DUser-Agent&s=800x600&c=24&j=1.6&v=N&k=Y&bw=800&bh=600&mcorgid=79655FCF5C1D42160A495E15%40AdobeOrg&AQE=1',
    frameUrl: 'https://www.spiegel.de/consent-a-?targetUrl=https%3A%2F%2Fwww.spiegel.de%2F',
    cpt: 'script',
    filter: '||sams.spiegel.de^'
  }
]

@antonok-edm antonok-edm mentioned this pull request Aug 11, 2021
Open
@antonok-edm
Copy link

Brave appears to have a problem blocking these:

Thanks for finding these @mjethani! I've described the root cause in brave/adblock-rust#183, likely this will involve increasing the maximum number of tokens.

@mjethani mjethani mentioned this pull request Aug 12, 2021
Merged
@mjethani
Copy link
Contributor

This work is done now after #2154

We can close this issue.

Now we have a new request data set and the latest versions of EasyList and EasyPrivacy.

Thanks to @remusao and everyone else for giving significant amounts of time to this.

@remusao
Copy link
Collaborator

remusao commented Aug 12, 2021

Thank you @mjethani for putting in all the work!

@mjethani
Copy link
Contributor

mjethani commented Aug 14, 2021 •
edited
Loading

Also, maybe would it make sense to create a Dockerfile to simplify running the setup in the future, without having to figure out all the dependencies required first.

If we do this, maybe we should also load a browser with a content blocking extension installed, make it navigate to all these sites, and record the background CPU usage, etc.

We could also use other kinds of data, such as the number of requests made from a document, the number of DOM nodes in a document, the number of subframes in a document, and so on, as this could help with design decisions.

@mjethani mjethani mentioned this pull request Aug 25, 2021
Closed
@remusao
Copy link
Collaborator

remusao commented Aug 26, 2021

@ameshkov @mjethani should we close this PR?

@mjethani
Copy link
Contributor

@ameshkov @mjethani should we close this PR?

The work is done as far as I can tell.

@remusao
Copy link
Collaborator

remusao commented Aug 26, 2021

Alright, closing. Thanks to both of you.

@remusao remusao closed this Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remusao remusao Awaiting requested review from remusao remusao is a code owner

Assignees
No one assigned
Labels
PR: Internal 🏠 Changes only affect internals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ameshkov @remusao @mjethani @antonok-edm @gorhill