Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike/get concepts associated with a document from vespa #459

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

katybaulch
Copy link
Contributor

Description

Add new endpoint to get concepts associated with a document from vespa.

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change
  • GitHub workflow update
  • Documentation update
  • Refactor legacy code
  • Dependency update

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Reviewer Checklist

  • DB_CLIENT DEPENDENCY IS ON THE LATEST VERSION
  • The PR represents a single feature (small driveby fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@katybaulch katybaulch requested review from a team as code owners February 6, 2025 16:48
@katybaulch katybaulch enabled auto-merge (squash) February 6, 2025 16:48
@jamesgorrie
Copy link

This would then allow us to use this endpoint on the document page in the frontend.

Copy link

@jamesgorrie jamesgorrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving all the 🐝 vespa love

@katybaulch katybaulch merged commit 153955f into main Feb 6, 2025
12 checks passed
@katybaulch katybaulch deleted the spike/get-concepts-associated-with-a-doc branch February 6, 2025 17:03
@katybaulch
Copy link
Contributor Author

We're currently getting all the concepts associated with all the documents in a family, but not all of those concepts will appear on all of the documents.

I want to see whether this gives me what i need to filter concepts on a specific document

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants