Feature/pdct 1398 map family to new json structure #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create more modular methods for mapping family data, separate out metadata into its own function.
tell the user we are skipping row if the metadata has missing information
- separate the test files into mapping family data and meta data - add more fixtures to conftest to test diff outcomes, i.e where we have missing metadata information
katybaulch
approved these changes
Sep 10, 2024
odrakes-cpr
deleted the
feature/pdct-1398-map-family-to-new-json-structure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Provide a general summary of your changes.
Updates the family data mapper to map the required fields for the family doc
Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.
Visit the Semver website to understand the
difference between
MAJOR,MINOR, andPATCHversions.Notes:
used -- e.g. Major > Minor > Patch
sure your selected option is marked
[x]with no spaces in between thebrackets and the
x