Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move search tests to sdk #178

Merged
merged 18 commits into from
Jan 20, 2025
Merged

Conversation

kdutia
Copy link
Member

@kdutia kdutia commented Jan 16, 2025

Description

Moves github.com/climatepolicyradar/search-tests/ into the SDK. Those tests are run separately to our current pytest setup.

Also updates the search CLI so now it's super easy for anyone with the SDK installed to run search queries in ✨debug mode✨

A ruff upgrade was also needed as match: ... case: ... wasn't supported in the version we were using (ref).

error: Failed to parse src/cpr_sdk/search_intention_testing/executors.py: invalid syntax. Got unexpected token 'test_case' at line 83 column 11
src/cpr_sdk/search_intention_testing/executors.py:83:12: E999 SyntaxError: invalid syntax. Got unexpected token 'test_case'
Found 1 error.

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail (integrated soon)
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

Copy link

linear bot commented Jan 16, 2025

@kdutia kdutia marked this pull request as ready for review January 16, 2025 13:45
@kdutia kdutia requested a review from a team as a code owner January 16, 2025 13:45
@kdutia kdutia marked this pull request as draft January 16, 2025 13:45
@kdutia kdutia marked this pull request as ready for review January 16, 2025 13:51
@kdutia kdutia requested a review from harrisonpim January 16, 2025 13:59
Copy link
Contributor

@jesse-c jesse-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I haven't gone deep into the tests themselves, since I know they've been used extensively in the previous repository.

@kdutia kdutia enabled auto-merge (squash) January 20, 2025 09:59
@kdutia kdutia merged commit 99a7cd4 into main Jan 20, 2025
6 checks passed
@kdutia kdutia deleted the feature/sci-93-move-search-tests-to-sdk branch January 20, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants