Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pla 378 bugfix indexer version bump #169

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

THOR300
Copy link
Collaborator

@THOR300 THOR300 commented Jan 2, 2025

Description

Moving datasets to an optional dependency as it's not required in all places that it's used and it's causing dependency conflicts.

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail (integrated soon)
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

Copy link

linear bot commented Jan 2, 2025

@THOR300 THOR300 marked this pull request as ready for review January 6, 2025 08:07
@THOR300 THOR300 requested a review from a team as a code owner January 6, 2025 08:07
@THOR300
Copy link
Collaborator Author

THOR300 commented Jan 6, 2025

This sdk version has been utilised in a draft pr in the indexer repo and run through integration tests successfully, thus opening as a PR for review.

Copy link
Contributor

@jesse-c jesse-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to know that it as optional does solve it!

@THOR300 THOR300 merged commit 6757b9f into main Jan 6, 2025
6 checks passed
@THOR300 THOR300 deleted the feature/pla-378-bugfix-indexer-version-bump branch January 6, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants