Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow aliasing event names #59

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Conversation

toddq
Copy link

@toddq toddq commented Mar 11, 2019

This might be a corner case, but my team is using docdash and would like to be able to use @alias with @event. We've made our event names available as constants on an object in the class, and would just like to alias them to display as Event.FOO instead of Event:FOO as that's how we expect our users to actually reference them.

@ar2rsawseen
Copy link
Collaborator

Sounds fine by me :)
I will publish new release, when I will retest the PR to remove jquery dependency. Will try to do it ASAP.

@ar2rsawseen ar2rsawseen merged commit 071aae4 into clenemt:master Mar 12, 2019
@toddq toddq deleted the alias-events branch April 4, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants