Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to crash agent on exception #123

Merged
merged 4 commits into from
Nov 6, 2022

Conversation

nielstenboom
Copy link
Contributor

Fixes #122

Adds a config option to allow the agent to crash when encountering an exception.

@jkhenning
Copy link
Member

@nielstenboom,

I think an alternative environment variable will be useful in this case, maybe CLEAMRL_AGENT_CRASH_ON_EXCEPTION?

@nielstenboom
Copy link
Contributor Author

I think an alternative environment variable will be useful in this case, maybe CLEAMRL_AGENT_CRASH_ON_EXCEPTION`?

Good point! I added it here: https://github.com/allegroai/clearml-agent/pull/123/files#diff-ecceb2e7426439a9803946e69186001bd26fe73f7fffd9fcee209afc65a56cebR89-R90 is it in the correct place there?

@jkhenning jkhenning merged commit 9eee213 into clearml:master Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

K8s Glue agent on Kubernetes fails silently
2 participants