-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add origins/condaforge Route for Consistent Conda API Structure #1279
Open
yashkohli88
wants to merge
14
commits into
clearlydefined:master
Choose a base branch
from
yashkohli88:yk/add-origins-condaforge
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add origins/condaforge Route for Consistent Conda API Structure #1279
yashkohli88
wants to merge
14
commits into
clearlydefined:master
from
yashkohli88:yk/add-origins-condaforge
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qtomlinson
reviewed
Feb 7, 2025
test/lib/condaRepoAccess.js
Outdated
}) | ||
}) | ||
|
||
describe('Conda Origin Routes', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_getOriginCondaRevisions is exposed on the router for testing purposes. Tests related to "Conda Origin Routes" may be better to remain in origin related tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses the need to enhance the API for Conda origins by creating a separate route for the Conda-Forge channel, thereby aligning it with the structure used for other package managers.
Key Changes:
origins/condaforge
Route:/origins/condaforge
.CondarepoAccess
library for better separation of concerns and reusability.originConda
and neworiginCondaforge
routes to useCondaRepoAccess
for accessing package data.Files Changed:
app.js
: Added route definition for Conda-Forge.lib/condaRepoAccess.js
: New library for handling Conda repository access.routes/originConda.js
: Refactored to leverageCondaRepoAccess
.routes/originCondaforge.js
: New route handler for Conda-Forge channel.test/lib/condaRepoAccess.js
: Added unit tests forCondaRepoAccess
.test/routes/origins.js
: Updated integration tests to accommodate new and refactored routes.Notes:
This PR is related to #1284