Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visa Direct - Purpose of payment #188

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Visa Direct - Purpose of payment #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
524a0f5
Add PoP to AFT
Lassejoe Mar 18, 2024
8d0f2de
Update PoP countries
Lassejoe Mar 18, 2024
6f18846
Add PoP field to OCT
Lassejoe Mar 18, 2024
2593828
Update text - Visa specific
Lassejoe Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion website/content/gateway/api_reference/resources/credits/credits.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ POST https://gateway.clearhaus.com/credits
{{% /description_details %}}

{{% description_term %}}currency{{% regex %}}[A-Z]{3}{{% /regex %}}{{% /description_term %}}
{{% description_details %}}[3-letter currency code](/currencies). (Some exponents differ from ISO 4217.)
{{% description_details %}}[3-letter currency code](/currencies). (Some exponents differ from ISO 4217.)
{{% /description_details %}}

{{% description_term %}}text_on_statement{{% regex %}}[\x20-\x7E]{2,22} [ASCII printable characters](https://en.wikipedia.org/wiki/ASCII#ASCII_printable_characters) {{% /regex %}}{{% /description_term %}}
Expand All @@ -32,6 +32,12 @@ POST https://gateway.clearhaus.com/credits
{{% regex_optional %}}Optional{{% /regex_optional %}}
{{% /description_details %}}

{{% description_term %}}purpose_of_payment {{% regex %}}[A-Z]{6}{{% /regex %}}{{% /description_term %}}
{{% description_details %}} The fields code shall reflect the nature and purpose of the transaction.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{% description_details %}} The fields code shall reflect the nature and purpose of the transaction.
{{% description_details %}}The fields code shall reflect the nature and purpose of the transaction.

IMHO we should try to converge towards not having these purposeless spaces 🙂

Valid codes are list in Visas Purpose of Payment - Standardized Codes List.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Valid codes are list in Visas Purpose of Payment - Standardized Codes List.
Valid codes are list in Visa's Purpose of Payment - Standardized Codes List.

{{% regex_optional %}} Required for Visa cross-border transactions destined for Argentina, Bangladesh, Chile, Columbia, Egypt, India and Mexico. {{% /regex_optional %}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{% regex_optional %}} Required for Visa cross-border transactions destined for Argentina, Bangladesh, Chile, Columbia, Egypt, India and Mexico. {{% /regex_optional %}}
{{% regex_optional %}}Required for Visa cross-border transactions destined for some specific countries; otherwise optional. See the partner guideline for details.{{% /regex_optional %}}

Maybe? 😬

{{% /description_details %}}

{{% description_term %}}card[pan] {{% regex %}}[0-9]{12,19}{{% /regex %}}{{% /description_term %}}
{{% description_details %}}Primary account number of card to charge.
{{% /description_details %}}
Expand Down
6 changes: 6 additions & 0 deletions website/content/gateway/api_reference/resources/debits/recipient_information.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,10 @@ Example: "Doe Jane A." (last name, first name, optional middle initial).
{{% regex_optional %}}Required if the merchant account's Business Application Identifier (BAI) is Funds Disbursement (FD).{{% /regex_optional %}}
{{% /description_details %}}

{{% description_term %}}recipient[purpose_of_payment] {{% regex %}}[A-Z]{6}{{% /regex %}}{{% /description_term %}}
Copy link
Contributor

@mt-clearhaus mt-clearhaus Mar 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Purpose of Payment is not related to recipient data so it does not make sense to have it in the recipient dictionary.

AFAICT, we should the same as for credits, i.e. have it on the same level as e.g. text_on_statement. Because the Debits section currently only refers to the parameters for an authorization, we need to add a Parameters section to debits, stating that these parameters are in addition to the parameters supported for an authorization.

{{% description_details %}} The fields code shall reflect the nature and purpose of the transaction.
Valid codes are list in Visas Purpose of Payment - Standardized Codes List.
{{% regex_optional %}} Required for Visa cross-border transactions destined for Argentina, Bangladesh, Chile, Columbia, Egypt, India and Mexico. {{% /regex_optional %}}
{{% /description_details %}}

{{% /description_list %}}