Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate non-tokenized MPO #159

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ct-clearhaus
Copy link
Member

No description provided.

@mt-clearhaus
Copy link
Contributor

There are some quirks to be ironed out, and I'm a bit puzzled over Hugo's behaviour ...

Screenshot from 2022-11-18 09-23-22

@mt-clearhaus
Copy link
Contributor

@Lassejoe Are you able to quickly see what is going on here? Why e.g. [:json:] will not stay on the same line as mobilepayonline[payment_token]?

@Lassejoe
Copy link
Contributor

image
should be fixed now by f0a8dff

@mt-clearhaus mt-clearhaus marked this pull request as ready for review November 18, 2022 09:54
@mt-clearhaus
Copy link
Contributor

@Lassejoe 🙏 🙇

@tjconcept
Copy link
Contributor

I asked MobilePay earlier this year if we could deprecate non-tokens, but they were pretty clear that especially Finnish cards were not tokenized, but in general they still have non-tokenized ones around. Do you have a more recent communiqué?

@ct-clearhaus
Copy link
Member Author

I asked MobilePay earlier this year if we could deprecate non-tokens, but they were pretty clear that especially Finnish cards were not tokenized, but in general they still have non-tokenized ones around. Do you have a more recent communiqué?

I haven't heard from MPO on this recently, but I also haven't seen any exemption on the fees from Mastercard for Finland so I wonder how this should work out.

@tjconcept
Copy link
Contributor

tjconcept commented Apr 13, 2023

We're still seeing use of this from MobilePay (I suppose you have that insight too), so I'm going to ask them once more. I'll keep you posted.

@ct-clearhaus
Copy link
Member Author

We're still seeing use of this from MobilePay (I suppose you have that insight too), so I'm going to ask them once more.

I can confirm.

I would like to deprecate non-tokenized MPO for multiple reasons, but the intention is to steer integrators towards the tokenized version as the primary and most important — to make sure tokenized is considered primary and non-tokenized is considered fallback (much like when 3DSv2 took over from 3DSv1). However, there are a few details that are unclear to me, so I'll likely end up "just" hinting this with text for now — which is indeed a much weaker statement — and leave this PR as an indication that it'll likely be coming (as opposed to indicating that the change is coming) 🙂

@tjconcept
Copy link
Contributor

the intention is to steer integrators towards the tokenized version

I actually don't think this is necessary. From our integration and communication with MobilePay, we have no say in this matter and simply act upon whether MobilePay ships us one or the other. Both are mandated for integrators to support. I specifically requested to skip the non-tokenized one but got rejected.
From experience it does seem like MobilePay prefers the tokenized version, as we are seeing non-tokenized versions appearing for instance after several failed attempts with tokenized ones.

steer integrators towards the tokenized version

This is how I normally understand "deprecated" (more like "discouraged/better exists"), so in that sense, I'd personally go right ahead and deprecate it. However, if you use the word differently, it would be awesome with some kind of statement as to "how urgently" we need to address these as they currently, at least theoretically, pose a serious and unknown risk to us.

@tjconcept
Copy link
Contributor

MobilePay replied suggesting us to respond to them with a "hard block" reason code once you remove support. In that case, I'd consider us in compliance with their mandate "to support".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants