This repository has been archived by the owner on May 6, 2020. It is now read-only.
cc-check should run all checks and display all warnings and errors #638
Assignees
Comments
jodh-intel
added a commit
to jodh-intel/runtime
that referenced
this issue
Sep 27, 2017
Change "cc-check" so that it always runs all commands before erroring. Previously, it would fail on first error, but this could mask the real reason for failure. For example, on a system with nesting and vhost disabled, "cc-check" would fail with a nesting error. But the nesting check is not strictly required (clearcontainers#281) whereas vhost definitely is which lead to confusing results for users. "cc-check" will now run all tests and display an error message at the end if any errors were found in the set of tests run. Fixes clearcontainers#638. Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel
added a commit
to jodh-intel/runtime
that referenced
this issue
Sep 27, 2017
Change "cc-check" so that it always runs all commands before erroring. Previously, it would fail on first error, but this could mask the real reason for failure. For example, on a system with nesting and vhost disabled, "cc-check" would fail with a nesting error. But the nesting check is not strictly required (clearcontainers#281) whereas vhost definitely is which lead to confusing results for users. "cc-check" will now run all tests and display an error message at the end if any errors were found in the set of tests run. Fixes clearcontainers#638. Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel
added a commit
to jodh-intel/runtime
that referenced
this issue
Sep 27, 2017
Change "cc-check" so that it always runs all commands before erroring. Previously, it would fail on first error, but this could mask the real reason for failure. For example, on a system with nesting and vhost disabled, "cc-check" would fail with a nesting error. But the nesting check is not strictly required (clearcontainers#281) whereas vhost definitely is which lead to confusing results for users. "cc-check" will now run all tests and display an error message at the end if any errors were found in the set of tests run. Fixes clearcontainers#638. Signed-off-by: James O. D. Hunt <[email protected]>
mcastelino
pushed a commit
to mcastelino/runtime
that referenced
this issue
Dec 6, 2018
Fixes clearcontainers#638. Latest kata-runtime can't build with golang 1.8.3, fix it for backward compatibility. Signed-off-by: Wei Zhang <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
cc-runtime cc-checkcurrently runs a series of tests but crucially errors when any test fails.This is a problem because, for example, if nesting is not enabled, currently
cc-checkwill fail. However, nesting isn't strictly necessary (see #281) and sincecc-checkfails for this, it masks the latest checks that really are hard requirements (like vhost being available).We need to change the logic of
cc-checkso that it always runs all tests and displays all results. If any error occurs, it should error only after running all tests.The text was updated successfully, but these errors were encountered: