Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

Revert "Fix go vet issues flagged by go 1.9" PR #615

Closed
jodh-intel opened this issue Sep 25, 2017 · 0 comments
Closed

Revert "Fix go vet issues flagged by go 1.9" PR #615

jodh-intel opened this issue Sep 25, 2017 · 0 comments
Assignees

Comments

@jodh-intel
Copy link
Contributor

#587 broke the CI and local unit-test builds. From http://cc-jenkins-ci.westus2.cloudapp.azure.com/job/clear-containers-runtime-azure-ubuntu-17-04/lastBuild/console:

INFO: Running 'go test' as current user on packages '.' with flags '-v -race -timeout 5s'
# github.com/clearcontainers/runtime/vendor/github.com/stretchr/testify/assert
vendor/github.com/stretchr/testify/assert/assertion_forward.go:21: undefined: Conditionf
vendor/github.com/stretchr/testify/assert/assertion_forward.go:45: undefined: Containsf
vendor/github.com/stretchr/testify/assert/assertion_forward.go:65: undefined: Emptyf
vendor/github.com/stretchr/testify/assert/assertion_forward.go:100: undefined: EqualErrorf
vendor/github.com/stretchr/testify/assert/assertion_forward.go:120: undefined: EqualValuesf
vendor/github.com/stretchr/testify/assert/assertion_forward.go:133: undefined: Equalf
vendor/github.com/stretchr/testify/assert/assertion_forward.go:157: undefined: Errorf
vendor/github.com/stretchr/testify/assert/assertion_forward.go:175: undefined: Exactlyf
vendor/github.com/stretchr/testify/assert/assertion_forward.go:190: undefined: FailNowf
vendor/github.com/stretchr/testify/assert/assertion_forward.go:195: undefined: Failf
vendor/github.com/stretchr/testify/assert/assertion_forward.go:195: too many errors
FAIL	github.com/clearcontainers/runtime [build failed]

With go1.8 and go1.9 I could build the runtime, but the tests would fail to compile. I don't understand how this passed under the 17.04 Jenkins CI whereas it now fails under the same system.

@jodh-intel jodh-intel self-assigned this Sep 25, 2017
@jodh-intel jodh-intel changed the title Revert Revert "Fix go vet issues flagged by go 1.9" PR Sep 25, 2017
jodh-intel added a commit to jodh-intel/runtime that referenced this issue Sep 25, 2017
…govet"

This reverts commit 535be19, reversing
changes made to 7e2466d.

This change broke the Jenkins CI and local unit-test builds (unable to
run them with either go 1.8 or go 1.9).

Fixes clearcontainers#615.

Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel added a commit to jodh-intel/runtime that referenced this issue Sep 25, 2017
…topic/govet"

This reverts commit 535be19, reversing
changes made to 7e2466d.

This change broke the Jenkins CI and local unit-test builds (unable to
run them with either go 1.8 or go 1.9).

Fixes clearcontainers#615.

Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel added a commit to jodh-intel/runtime that referenced this issue Sep 25, 2017
…topic/govet"

This reverts commit 535be19, reversing
changes made to 7e2466d.

This change broke the Jenkins CI and local unit-test builds (unable to
run them with either go 1.8 or go 1.9).

Fixes clearcontainers#615.

Signed-off-by: James O. D. Hunt <[email protected]>
@sameo sameo removed the in progress label Sep 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants