-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
||
* Update clear-containers-image from 18220 to 18400. | ||
|
||
version: 18280 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of this descriptive text needs to be indented as it is currently making this changelog file "invalid". See:
Note that you can check when the file is valid by doing:
$ sudo apt-get -y install dpkg-dev
$ dpkg-parsechangelog -l /path/to/your/changelog
If the dpkg-parsechangelog
command outputs anything to stderr
, the file is invalid (it seems that checking the exit code isn't reliable as the command attempts to recover and ignore bad input).
This image contains relevant changes: - clearcontainers/agent#131 Fixes #157 Signed-off-by: Erick Cardona <[email protected]>
@jodh-intel Fixed |
* Update clear-containers-image from 18220 to 18400. | ||
|
||
* version: 18280 | ||
Changes in package iptables (from 1.6.1-20 to 1.6.1-21): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I'd personally indent a little more (something like the following for maximum clarity - this is also still valid):
* version: 18280
Changes in package iptables (from 1.6.1-20 to 1.6.1-21):
George T Kramer - iptables: Autospec creation for version 1.6.1
https://download.clearlinux.org/releases/18280/clear/RELEASENOTES
We need to update clear-containers rootfs image and the kernel that is being used in testing. * Image: Updated agent with a fix for deadlock clearcontainers/packaging#158 * Kernel: Add support for native hot plug clearcontainers/packaging#133 Fix 9p fs unlink-ftruncate clearcontainers/packaging#110 Fixes clearcontainers#631 Signed-off-by: Geronimo Orozco <[email protected]>
The osbuilder version file wont be the same if we tag a stable branch. But we still want to tag the HEAD of osbuilder to do reproducible builds of a Kata branch. Fixes: clearcontainers#158 Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
This image contains relevant changes:
Fixes #157
Signed-off-by: Erick Cardona [email protected]