Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

image: remove debtools and use _service file #120

Merged
merged 1 commit into from
Oct 9, 2017
Merged

image: remove debtools and use _service file #120

merged 1 commit into from
Oct 9, 2017

Conversation

erick0z
Copy link

@erick0z erick0z commented Sep 21, 2017

This commit removes packaging tools dependencies (debtools)
and let OBS services do most of the work (create debian tarball,
download sources, etc).

Fixes #94

This now uses the tarballed image provided by clearlinux.org https://download.clearlinux.org/releases/1080/clear-18080-containers.tar.xz

Packages updated in the staging area: https://build.opensuse.org/package/show/home:clearcontainers:clear-containers-3-staging/clear-containers-image

This is a prework to automate all the packages creation, with the goal of having a CI (issue #103 ). Having a _service file for every repository will allow us to create packages automatically after a change has landed.

@gorozco1
Copy link

Related to #103

Copy link

@gorozco1 gorozco1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a repo under clearcontainers for the image.

<services>
<service name="tar_scm">
<param name="scm">git</param>
<param name="url">https://github.com/erick0z/clear-containers-image.git</param>
Copy link

@gorozco1 gorozco1 Sep 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use a repository under clearcontainers group:

@jodh-intel thoughts?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed - it's not a good idea to download from a users repo.

But, rather than copying files from https://download.clearlinux.org/releases/ to a github repo, can we instead use one of these plugins to just download the image file from https://download.clearlinux.org using one of the other OBS services such as download_url?:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that doesn't work, we could look at using the download_files service which sounds like it might be able to grab the spec file from this repo and download the associated clear-containers.img file?:

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jodh-intel we already use those OBS services (downloading golang tarball, for instance). The thing is, in this case, the format of the file. Since the image is the source of the package, for debian builds, it must be a tarball. That's why I used my personal repo for testing. Anyway, I think a tarballed image will be published in clearlinux.org, making it easier for us.

@erick0z
Copy link
Author

erick0z commented Oct 2, 2017

@gorozco1 updated PR with the new download link.

Copy link

@gorozco1 gorozco1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This commit removes packaging tools dependencies (debtools) and
let OBS services do most of the work (create debian tarball,
download sources, etc).

Fixes #94

Signed-off-by: Erick Cardona <[email protected]>
Copy link

@gorozco1 gorozco1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove changelog from this PR till we have released the package to the official repo.

@erick0z
Copy link
Author

erick0z commented Oct 9, 2017

@gorozco1 done.

@gorozco1
Copy link

gorozco1 commented Oct 9, 2017

@erick0z @jcvenegas could you update the version in this PR. and forget about #138

@jcvenegas
Copy link
Contributor

@gorozco1 closed.

@jcvenegas
Copy link
Contributor

@erick0z the image to be updated is 18220

@erick0z
Copy link
Author

erick0z commented Oct 9, 2017

@jcvenegas @gorozco1 just updated versions.txt

<service name="download_url">
<param name="protocol">https</param>
<param name="host">download.clearlinux.org</param>
<param name="path">/image/clear-@[email protected]</param>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This url should be pointing to /releases/@VERSION@/clear/

Version: @VERSION@-@RELEASE@
Section: devel
Priority: optional
Maintainer: clearlinux.org team <[email protected]>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be changed to Clear Containers and external mailing list not clear linux

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer: clear containers team [email protected]

@erick0z
Copy link
Author

erick0z commented Oct 9, 2017

@gorozco1 I think it is ready.

@gorozco1 gorozco1 merged commit 37a03cb into clearcontainers:master Oct 9, 2017
@erick0z erick0z deleted the image_service branch October 18, 2017 22:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants