Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

kill: Deadlock waiting for a kill to be completed #130

Closed
sboeuf opened this issue Oct 12, 2017 · 0 comments · Fixed by #131
Closed

kill: Deadlock waiting for a kill to be completed #130

sboeuf opened this issue Oct 12, 2017 · 0 comments · Fixed by #131

Comments

@sboeuf
Copy link
Contributor

sboeuf commented Oct 12, 2017

In few cases, we end up waiting forever for our container to be signalled. This issue comes from a libcontainer issue here: opencontainers/runc#1609 that has been solved with opencontainers/runc#1610
We need to re-vendor our agent in order to get the fix.

sboeuf pushed a commit that referenced this issue Oct 12, 2017
This commit updates runc vendoring, the most important reason is that
we want the fix of opencontainers/runc#1609
to be included into our agent.

Fixes #130

Signed-off-by: Sebastien Boeuf <[email protected]>
sboeuf pushed a commit that referenced this issue Oct 12, 2017
Even if the source of our kill deadlock bug has been solved through
libcontainer directly, we might want to avoid any potential lock
when issuing a signal to a container. That's why this patch introduces
a timeout after which we consider the kill command as failing.
Moreover, it will show us easily if we're getting caught in such a case
in the future, by printing important logs.

Fixes #130

Signed-off-by: Sebastien Boeuf <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant