Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify so gauge values always written at start time regardless of min_time_increment #636

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

rjleveque
Copy link
Member

Previously if min_time_increment > 0 was set for a gauge it wouldn't capture the gauge value until this long after the starting time value t1 specified for the gauge.

@mandli
Copy link
Member

mandli commented Feb 10, 2025

This should also be added to AMRClaw I suppose.

I was also trying to think of a way to do this without having to loop through the gauges twice but different types of data seems to make that difficult without looping twice.

rjleveque added a commit to rjleveque/amrclaw that referenced this pull request Feb 11, 2025
@rjleveque
Copy link
Member Author

By the way, I also tried to make it print the gauges at the final time in the calculation, since currently the gauge output is done before the call to stepgrid on each grid. But it's done that way so that ghost cell values have been filled in already, which in general are needed if interpolation is used to get the gauge value. (In practice we try to insure that gauges are at the centers of grid cells on the finest level but that's not always practical.). Anyway, I don't see any easy to fix this.

@mandli mandli merged commit 369fd62 into clawpack:master Feb 17, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants