add runtime typechecks for sortable IDs and items. #734
Conversation
|
| // the process.env guard will cause this check to be removed from the bundle | ||
| // at build time by most modern build tools | ||
| if (process.env.NODE_ENV !== 'production') { | ||
| if (items.every((i) => typeof id === 'string')) { |
There was a problem hiding this comment.
Because SortableContext is relatively high up in the render tree, I don't think this will cause perf issues in development but because it's iterating over the items array, it does have the potential to.
This check could be memoized but it would need to use something besides React.useMemo in order to avoid the hooks linter complaining about hooks inside a conditional (even if that conditional will never change at runtime...)
Marking this as a draft because I still need to NPM link this into my project and manually test it.
Resolves #606