-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CL-16691: Support Okta Access token #148
base: master
Are you sure you want to change the base?
Conversation
We can pass okta generated access token to call endpoints |
src/ClassyResource/_makeRequest.js
Outdated
@@ -32,7 +32,7 @@ export default function _makeRequest(path, method, headers = {}, form, data = {} | |||
: undefined; | |||
|
|||
const requestParams = { | |||
baseUrl: this.baseUrl, | |||
baseUrl: baseUrl ? baseUrl : this.baseUrl, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does this.baseUrl
get set? I'd prefer that we update that value in the appropriate place if config.oktaBaseUrl
is passed in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.baseUrl is set in src/ClassyResource/main.js. In that we are not getting request payload to check is_okta_token flag.
I am removing this change from here and updating the this.baseUrl value in src/ClassyResource/createMethod.js file. I have updated the code, please review.
High level these changes look good. We'd want to make sure we have documentation that details what we're doing and why in the README and also comments in the code. I'm going to hold off on "approving" for now. We'll want to look into how we can potentially publish your fork to our private registry so that we can do tests before we merge. |
Hi @ESoch |
Cl 16691 - Yarn & CA Changes
No description provided.