Boehm cleanup #1664
Merged
Boehm cleanup #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of it I don't understand the logic of. Why would we ever need to know the size of a forwarding pointer? Even if we did, we could just follow the pointer and see how big the forwarded object is. And I don't see any purpose for the OBJECT_SIZE etc in obj_scan, since we can just set forwarding pointers from the header.
no point being coy about it with stampP, we're doing low level stuff here and it's cleaner to just have the one switch.
not really used anyway. i kinda want to delete the debug code entirely but i'll hold off for a moment
it's bitrotten, and also the boehm docs are pretty clear that mark procedures should only be a last resort if a bitmap isn't adequate. We're already not using bitmaps in boehm, so why would we want mark procedures?
Our custom kinds have identical properties to GC_I_NORMAL. So all making them accomplishes is preventing the system from using threadlocal freelists (without a bit of internal hacking these only seem to exist for the builtin kinds, normal and pointerfree)
Why were we forcing global allocations?
not sure how kosher it is to update the autoconf-generated config.h manually. oh well
the static analyzer no longer analyzes WeakPointer, and as such there's no reason to restrict the use of a smart pointer. Ephemerons still need a disguised pointer, unfortunately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades to boehm gc 8.2.8 and cleans up some old code. More importantly, it enables the use of thread-local allocation, which should make consing more efficient in a multi threaded program.