Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 498 #499

Merged
merged 9 commits into from
May 10, 2016
Merged

Issue 498 #499

merged 9 commits into from
May 10, 2016

Conversation

kbknapp
Copy link
Member

@kbknapp kbknapp commented May 9, 2016

DO NOT MERGE

@yo-bot
Copy link

yo-bot commented May 9, 2016

r? @Vinatorul

(yo-bot has picked a reviewer for you, use r? to override)

kbknapp added 5 commits May 9, 2016 19:14
For example, if an arg is part of a required group, it will only appear
in the group usage string, and not in both the group as well as the arg
by itself.

Imagine a group containing two args, `arg1` and `--arg2`

OLD:
    `myprog <arg1> <arg1|--arg2>`

NEW:
    `myprog <arg1|--arg2>`

Closes #498
@coveralls
Copy link

Coverage Status

Coverage increased (+3.6%) to 89.301% when pulling 417dbc3 on issue-498 into cff9457 on master.

@kbknapp
Copy link
Member Author

kbknapp commented May 9, 2016

@homu r+

@homu
Copy link
Contributor

homu commented May 9, 2016

📌 Commit 417dbc3 has been approved by kbknapp

homu added a commit that referenced this pull request May 9, 2016
homu added a commit that referenced this pull request May 9, 2016
@homu
Copy link
Contributor

homu commented May 9, 2016

⌛ Testing commit 417dbc3 with merge c8c20a0...

@homu
Copy link
Contributor

homu commented May 10, 2016

☀️ Test successful - status

@homu homu merged commit 417dbc3 into master May 10, 2016
@kbknapp kbknapp deleted the issue-498 branch May 10, 2016 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants