CI for v2-master #1673
Merged
CI for v2-master #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CreepySkeleton
approved these changes
Feb 5, 2020
| * As of this release, `clap` requires `rustc 1.33.0` or greater. | ||
| * As of this release, `clap` requires `rustc 1.36.0` or greater. |
There was a problem hiding this comment.
It's theoretically a breaking change, but 1.33 if pretty old and it's unlikely that many people still use it
There was a problem hiding this comment.
It's not actually a breaking change since we hadn't released the 1.33 version bump. Also, in README, we say that Clap supports stable minus 2 versions.
There was a problem hiding this comment.
It is a breaking change. Though note we won't be releasing a new 2.0 version unless it's an emergency
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Feb 5, 2020
1673: CI for v2-master r=CreepySkeleton a=pksunkara This should make the `v2-master` branch good for maintenance. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/clap-rs/clap/1673) <!-- Reviewable:end --> Co-authored-by: Pavan Kumar Sunkara <[email protected]>
Timed out |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Feb 5, 2020
1673: CI for v2-master r=CreepySkeleton a=pksunkara This should make the `v2-master` branch good for maintenance. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/clap-rs/clap/1673) <!-- Reviewable:end --> Co-authored-by: Pavan Kumar Sunkara <[email protected]>
|
@pksunkara looks like bors is some kind of broken |
|
This is v2-master branch |
|
bors r- |
Canceled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make the
v2-masterbranch good for maintenance.This change is