Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle the extension into one js file with esbuild. #287

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Bundle the extension into one js file with esbuild. #287

merged 1 commit into from
Jan 27, 2022

Conversation

sam-mccall
Copy link
Member

This reduces vsix size from 1.5MB -> 500KB, and activate time by 60ms or so.

Note that esbuild consumes TS directly rather than running tsc, and
doesn't produce diagnostics. However they still show up in the editor,
and test will still fail on tsc compile errors.

@sam-mccall
Bundle the extension into one js file with esbuild.
7a5203a 
This reduces vsix size from 1.5MB -> 500KB, and activate time by 60ms or so.

Note that esbuild consumes TS directly rather than running tsc, and
doesn't produce diagnostics. However they still show up in the editor,
and `test` will still fail on tsc compile errors.
@sam-mccall sam-mccall requested a review from kadircet January 25, 2022 16:27
@sam-mccall sam-mccall merged commit 21cc1a5 into master Jan 27, 2022
@sam-mccall sam-mccall deleted the bundle branch January 27, 2022 16:09
@hokein hokein mentioned this pull request Apr 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadircet kadircet kadircet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sam-mccall @kadircet