PARQUET-2466: Simplify logic when calling ParquetWriter (apache#1338)

I think this is easier to read
clairemcginty · May 17, 2024 · 0decc2b · 0decc2b
1 parent de01478
commit 0decc2b
Showing 1 changed file with 15 additions and 27 deletions.
diff --git a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetWriter.java b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetWriter.java
@@ -911,33 +911,21 @@ public ParquetWriter<T> build() throws IOException {
       if (codecFactory == null) {
         codecFactory = new CodecFactory(conf, encodingProps.getPageSizeThreshold());
       }
-      if (file != null) {
-        return new ParquetWriter<>(
-            file,
-            mode,
-            getWriteSupport(conf),
-            codecName,
-            codecFactory,
-            rowGroupSize,
-            enableValidation,
-            conf,
-            maxPaddingSize,
-            encodingProps,
-            encryptionProperties);
-      } else {
-        return new ParquetWriter<>(
-            HadoopOutputFile.fromPath(path, ConfigurationUtil.createHadoopConfiguration(conf)),
-            mode,
-            getWriteSupport(conf),
-            codecName,
-            codecFactory,
-            rowGroupSize,
-            enableValidation,
-            conf,
-            maxPaddingSize,
-            encodingProps,
-            encryptionProperties);
-      }
+
+      return new ParquetWriter<>(
+          (file != null)
+              ? file
+              : HadoopOutputFile.fromPath(path, ConfigurationUtil.createHadoopConfiguration(conf)),
+          mode,
+          getWriteSupport(conf),
+          codecName,
+          codecFactory,
+          rowGroupSize,
+          enableValidation,
+          conf,
+          maxPaddingSize,
+          encodingProps,
+          encryptionProperties);
     }
   }
 }