Expect autoformat delimiters to have a space character preceding them. #8619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbarnas
force-pushed
the
i/2388
branch
3 times, most recently
from
e11301f to
5c59f79
Compare
maxbarnas
commented
Dec 10, 2020
| @@ -80,17 +80,17 @@ export default class Autoformat extends Plugin { | |||
| if ( commands.get( 'bold' ) ) { | |||
| const boldCallback = getCallbackFunctionForInlineAutoformat( this.editor, 'bold' ); | |||
|
|
|||
| inlineAutoformatEditing( this.editor, this, /(\*\*)([^*]+)(\*\*)$/g, boldCallback ); | |||
| inlineAutoformatEditing( this.editor, this, /(__)([^_]+)(__)$/g, boldCallback ); | |||
| inlineAutoformatEditing( this.editor, this, /(?:^|\s)(\*\*)([^*]+)(\*\*)$/g, boldCallback ); | |||
There was a problem hiding this comment.
Could add a comment explaining why I added this here. Not sure if that's necessary.
maxbarnas
commented
Dec 10, 2020
| @@ -577,24 +613,24 @@ describe( 'Autoformat', () => { | |||
|
|
|||
| describe( 'should format', () => { | |||
| it( '* after', () => { | |||
| setData( model, '<paragraph><$text code="true">fo*o</$text>b*ar[]</paragraph>' ); | |||
| setData( model, '<paragraph><$text code="true">fo*o</$text>b *ar[]</paragraph>' ); | |||
There was a problem hiding this comment.
I've changed the test to let it format according to PR changes.
maxbarnas
changed the title
|
All looks fine, but it'd be good to have a clarity on cases that you ignored and that will become possible followups. Some that I can think of:
What else did you skip? It'd be good to have tickets for these scenarios. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (autoformat): Formatting will not be applied to
snake_case_scenarioanymore. Closes #2388.