Pressing the tab key in restricted editing mode enters a table thats non editable #16070
Conversation
…d-editing-mode-enters-a-table-thats-non-editable
arkflpc
requested review from
niegowski and
arkflpc
and removed request for
niegowski
packages/ckeditor5-restricted-editing/src/restrictededitingmodeediting.ts
Outdated
Show resolved
Hide resolved
| @@ -287,6 +287,7 @@ export function toWidgetEditable( | |||
| writer.addClass( [ 'ck-editor__editable', 'ck-editor__nested-editable' ], editable ); | |||
|
|
|||
| writer.setAttribute( 'role', 'textbox', editable ); | |||
| writer.setAttribute( 'tabindex', '-1', editable ); | |||
There was a problem hiding this comment.
How would it behave if the whole editor has other tabindex set by integrators? For instance tablindex=-2. Was it tested (in manual test or otherwise)?
There was a problem hiding this comment.
In that case, it would behave the same
There was a problem hiding this comment.
From MDN:
A negative value (the exact negative value doesn't actually matter, usually tabindex="-1") means that the element is not reachable via sequential keyboard navigation.
Note: tabindex="-1" may be useful for elements that should not be navigated to directly using the Tab key, but need to have keyboard focus set to them. Examples include an off-screen modal window that should be focused when it comes into view, or a form submission error message that should be immediately focused when an errant form is submitted.
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex
niegowski
deleted the
ck/15506-pressing-the-tab-key-in-restricted-editing-mode-enters-a-table-thats-non-editable
branch
Suggested merge commit message (convention)
Fix (widget): Pressing tab should not focus widget editable. Closes #15506.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.