Add the visual label to the beginning of the programmatic heading dropdown aria label #16024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in heading dropdown
oleq
requested changes
Mar 19, 2024
There was a problem hiding this comment.
The solution is correct. What we're missing:
- unit tests,
and as per original issue
The same issue exists in other dropdown controls.
- an integration with text part language (the aria-label is "Language" but it displays "French")
| @@ -124,6 +124,21 @@ export default class HeadingUI extends Plugin { | |||
| return titles[ whichModel ]; | |||
| } ); | |||
|
|
|||
| dropdownView.buttonView.bind( 'ariaLabel' ).to( headingCommand, 'value', paragraphCommand, 'value', ( value, para ) => { | |||
| const whichModel = value || para && 'paragraph'; | |||
There was a problem hiding this comment.
Since we're visiting this code for the first time since 2018, can you please rewrite it to human-readable code using if/else or at least the ternary operator? 🙂 (I know you copied it from dropdownView.buttonView.bind( 'label' )..., you can change it there too)
There was a problem hiding this comment.
I reduced this one line to const whichModel = paragraph ? 'paragraph' : heading;. Seems to be working correctly.
oleq
requested changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (heading): Set the visual label to the beginning of the programmatic aria label in heading and language dropdowns.
Closes https://github.com/cksource/ckeditor5-commercial/issues/6029