Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste from Office should not break the list on the following blocks in the same list item or deduce a start attribute for a split list #16007

Merged
merged 19 commits into from
Mar 29, 2024

Conversation

niegowski
Copy link
Contributor

@niegowski niegowski commented Mar 8, 2024

Suggested merge commit message (convention)

Fix (paste-from-office): Paste from Office should not break the list on the following blocks in the same list item or deduce a start attribute for a split list. Closes #11210, closes #15964.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@Witoso
Copy link
Member

Witoso commented Mar 11, 2024

Self-reminder to put it into the comparison table. cc: @gorzelinski @godai78

@niegowski niegowski marked this pull request as ready for review March 22, 2024 12:23
Copy link
Contributor

@pszczesniak pszczesniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution covers most of mention cases, but i have found one case when it does not.

Here is the file: broken-list.docx

Screenshot 2024-03-25 at 08 41 48

Please take a look at the indentation level, first one is "flattened" (as a proper list should look like - without omit the levels of lists).

Screenshot 2024-03-25 at 08 43 46

CKE4 covers that case.

Screenshot 2024-03-25 at 08 44 03

@Witoso
Copy link
Member

Witoso commented Mar 25, 2024

@pszczesniak  we don't have support in CKE5 for so called "skip-level" lists, so the behavior is correct :)

@pszczesniak
Copy link
Contributor

@Witoso thank you for clearing that up.

@niegowski niegowski merged commit a25e3f2 into master Mar 29, 2024
7 checks passed
@niegowski niegowski deleted the ck/11210 branch March 29, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants