Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste from word should work for legal list only #15982

Merged

Conversation

illia-stv
Copy link
Contributor

Suggested merge commit message (convention)

Fix (Paste-from-office): When paste from word should recognise legal list only. Closes #6019.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@illia-stv illia-stv self-assigned this Mar 5, 2024
@illia-stv
Copy link
Contributor Author

Fix explanation:
We noticed multi level list have mso-level-number-format attribute except legal lists, so we used that. If list has legal list match and doesn't has mso-level-number-format we are assigning legal-list class.

@illia-stv illia-stv changed the base branch from cc/epic/multi-level-list to master March 5, 2024 11:30
@illia-stv illia-stv changed the base branch from master to cc/epic/multi-level-list March 5, 2024 11:30
Copy link
Contributor

@mmotyczynska mmotyczynska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

I tried to find all variables containing legal word and propose a change so they are more descriptive. If you find more please also change them so they contain legalStyleList phrase rather than simply legal or legalType (as now we treat it as a style, not a type).

Other than that, please also add a dedicated test with a Word file containing an example of legal-style list and multi-level lists.

@illia-stv illia-stv requested a review from mmotyczynska March 5, 2024 14:26
@illia-stv
Copy link
Contributor Author

Works as expected.

I tried to find all variables containing legal word and propose a change so they are more descriptive. If you find more please also change them so they contain legalStyleList phrase rather than simply legal or legalType (as now we treat it as a style, not a type).

Other than that, please also add a dedicated test with a Word file containing an example of legal-style list and multi-level lists.

There are already Word files which contain all kinds of multi list (legal lists included). In case with legal list our logic adds legal-list class, and current test modification cover that case as other cases with multi level (not legal) list which should have behaviour as previously.

@Witoso
Copy link
Member

Witoso commented Mar 5, 2024

Should we leak this class if someone has not enabled Multi-level list plugin? I feel this may be unintended in a case when a plugin is not used.

@illia-stv illia-stv requested a review from mmotyczynska March 8, 2024 13:10
@niegowski niegowski merged commit 954fdf0 into cc/epic/multi-level-list Mar 12, 2024
1 check was pending
@niegowski niegowski deleted the ck/15955-PFW-should-work-for-legal-only branch March 12, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants