Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing focus after escaping find and replace dropdown #10523

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Fixing focus after escaping find and replace dropdown #10523

merged 1 commit into from
Sep 14, 2021

Conversation

mateuszzagorski
Copy link
Contributor

Suggested merge commit message (convention)

Fix (find-and-replace): The toolbar should not lose focus after escaping from the find and replace dropdown. Closes #10420.

Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

mlewand
mlewand approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@mlewand mlewand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one, nice and simple 👍

@mlewand mlewand modified the milestone: iteration 47 Sep 14, 2021
@mlewand mlewand merged commit a5e0392 into master Sep 14, 2021
@mlewand mlewand deleted the ck/10420-toolbar-focus-find-and-replace branch September 14, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlewand mlewand mlewand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toolbar loses focus after escaping from the find and replace dropdown
2 participants
@mateuszzagorski @mlewand